YAMLs and Python script for the GOES CSR BUFR#61
Open
PraveenKumar-NOAA wants to merge 2 commits intodevelopfrom
Open
YAMLs and Python script for the GOES CSR BUFR#61PraveenKumar-NOAA wants to merge 2 commits intodevelopfrom
PraveenKumar-NOAA wants to merge 2 commits intodevelopfrom
Conversation
PraveenKumar-NOAA
requested review from
emilyhcliu,
nicholasesposito and
rmclaren
Contributor
nicholasesposito
left a comment
nicholasesposito
left a comment
There was a problem hiding this comment.
Just one comment but the rest looks good.
| longName: "Brightness Temperature" | ||
| units: "K" | ||
|
|
||
| - name: "ObsValue/brightnessTemperatureStandardDeviation" |
Contributor
There was a problem hiding this comment.
Curious if this is an ObsValue? Thinking this would be better in MetaData but I'm open to discussing it.
Contributor
Author
|
@emilyhcliu I have created brightnessTemperature plots for the g16 and g17 channels and added to the following isses -- #57. |
HyundeokChoi-NOAA
added a commit
that referenced
this pull request
Apr 7, 2026
…m Praveen.Kumar (#101) This PR have 2 updates. 1. Enable extraction of redistribution‑restriction metadata by adding restrictionFlag (RSRD) and restrictionExpiration (EXPRSRD) to the BUFR→IODA conversion. This ensures downstream restriction‑filter logic has the required fields available in MetaData. 2. Add modified IODA-Converters that originally from Praveen in PRs (#45, #55, #61, #62, #69). --------- Co-authored-by: hyundeok choi <[email protected]> Co-authored-by: hyundeok choi <[email protected]> Co-authored-by: Cory Martin <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: hyundeok choi <[email protected]> Co-authored-by: hyundeok choi <[email protected]> Co-authored-by: hyundeok choi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following files for the GSR CSR BUFR converter:
Testing and Validation
All four workflows (bufr2netcdf, bufr4backend, script2netcdf, and script4backend) were executed and tested using serial execution.
Validation tests were completed for the following variables:
-- satelliteZenithAngle
-- cloudFree
-- brightnessTemperature (Min and Max values are not matching with BUFR, looking at GSI file and debugging it, for details look at the issue #57)
The validation was performed by comparing the input BUFR files and the corresponding output IODA files. Additional details can be found in #57.
Python Coding Standards:
The spoc_python_coding_norms test was run to check compliance with Pycodestyle standards.
The following tests passed:
spoc_python_coding_norms
100% tests passed, 0 tests failed out of 1
Variable Naming Validation:
The following two variables need to be added to the variable naming table (a discussion is needed for these):
Variable MetaData/brightnessTemperaturePercentConfidence
ERROR: Variable 'MetaData/brightnessTemperaturePercentConfidence' is not listed in the YAML conventions file.
Variable MetaData/sensorBandWidth
ERROR: Variable 'MetaData/sensorBandWidth' is not listed in the YAML conventions file.