-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/add ctests nick e #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicholasesposito
wants to merge
21
commits into
main
Choose a base branch
from
feature/add_ctests_NickE
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
44fd45b
Add Ctests for obsForge
emilyhcliu cf52140
fix typo
emilyhcliu 84f6a97
add files related to coding norms check
emilyhcliu e2654c1
change filename e.g. bufr_backend to bufr4backend and add bound to time.
emilyhcliu 4640b1b
Remove files
emilyhcliu 2e728fe
Update test names and directory names
emilyhcliu ac60d23
add adpsfc, sfcshp, acft_profiles prepbufr tests
c4a112d
cmakelists update, add yamls and update paths
deefb54
also add script4backend
f4b39a3
rm *mpi0*
4ee3225
input filename changes, gz edits
e0963a0
does this help
d9113dd
small changes to cmake
9438771
prepufr -> prepbufr
nicholasesposito 3c6e524
init changes test/cmakelists.txt
9a2aa84
CMakeLists.txt now test on hera
2e94fe3
edit script locations
nicholasesposito 996103a
update mapping file path bufr_bufr4backend_acft_profiles_prepbufr_mpi…
nicholasesposito feee6c1
generate test update, works for list of types
nicholasesposito e0a7cde
add adpupa_prepbufr
nicholasesposito 5ad3a81
idk where these satwnd_amv_goes files came from
nicholasesposito File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
test/testinput/bufr_bufr4backend_acft_profiles_prepbufr.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| time window: | ||
| begin: "2021-07-31T21:00:00Z" | ||
| end: "2021-08-01T03:00:00Z" | ||
| bound to include: begin | ||
|
|
||
| observations: | ||
| - obs space: | ||
| name: "AIRCFT" | ||
| simulated variables: ['airTemperature','specificHumidity','windNorthward','windEastward'] | ||
| obsdatain: | ||
| engine: | ||
| type: bufr | ||
| obsfile: "./testdata/gdas.t00z.prepbufr.acft_profiles" | ||
| mapping file: "./testinput/bufr_acft_profiles_prepbufr_mapping.yaml" | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: "./testrun/bufr4backend/gdas.t00z.acft_profiles_prepbufr.tm00.nc" |
18 changes: 18 additions & 0 deletions
18
test/testinput/bufr_bufr4backend_acft_profiles_prepbufr_mpi4.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| time window: | ||
| begin: "2021-07-31T21:00:00Z" | ||
| end: "2021-08-01T03:00:00Z" | ||
| bound to include: begin | ||
|
|
||
| observations: | ||
| - obs space: | ||
| name: "AIRCFT" | ||
| simulated variables: ['airTemperature','specificHumidity','windNorthward','windEastward'] | ||
| obsdatain: | ||
| engine: | ||
| type: bufr | ||
| obsfile: "./testdata/gdas.t00z.prepbufr.acft_profiles" | ||
| mapping file: "./testinput/bufr_acft_profiles_prepbufr_mapping.yaml" | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: "./testrun/bufr4backend/gdas.t00z.acft_profiles_prepbufr.tm00_mpi4.nc" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| time window: | ||
| begin: "2021-07-31T21:00:00Z" | ||
| end: "2021-08-01T03:00:00Z" | ||
| bound to include: begin | ||
|
|
||
| observations: | ||
| - obs space: | ||
| name: "ADPSFC" | ||
| simulated variables: ['stationElevation','stationPressure'] | ||
| obsdatain: | ||
| engine: | ||
| type: bufr | ||
| obsfile: "./testdata/gdas.t00z.prepbufr" | ||
| mapping file: "./testinput/bufr_adpsfc_prepbufr_mapping.yaml" | ||
| # category: ["goes-16"] | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: "./testrun/bufr4backend/gdas.t00z.adpsfc_prepbufr.tm00.nc" |
19 changes: 19 additions & 0 deletions
19
test/testinput/bufr_bufr4backend_adpsfc_prepbufr_mpi4.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| time window: | ||
| begin: "2021-07-31T21:00:00Z" | ||
| end: "2021-08-01T03:00:00Z" | ||
| bound to include: begin | ||
|
|
||
| observations: | ||
| - obs space: | ||
| name: "ADPSFC" | ||
| simulated variables: ['stationElevation','stationPressure'] | ||
| obsdatain: | ||
| engine: | ||
| type: bufr | ||
| obsfile: "./testdata/gdas.t00z.prepbufr" | ||
| mapping file: "./testinput/bufr_adpsfc_prepbufr_mapping.yaml" | ||
| # category: ["goes-16"] | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: "./testrun/bufr4backend/gdas.t00z.adpsfc_prepbufr.tm00_mpi4.nc" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| time window: | ||
| begin: "2021-07-31T21:00:00Z" | ||
| end: "2021-08-01T03:00:00Z" | ||
| bound to include: begin | ||
|
|
||
| observations: | ||
| - obs space: | ||
| name: "SFCSHP" | ||
| simulated variables: ['stationPressure','airTemperature','virtualTemperature','specificHumidity','windNorthward','windEastward'] | ||
| obsdatain: | ||
| engine: | ||
| type: bufr | ||
| obsfile: "./testdata/gdas.t00z.prepbufr" | ||
| mapping file: "./testinput/bufr_sfcshp_prepbufr_mapping.yaml" | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: "./testrun/bufr4backend/gdas.t00z.sfcshp_prepbufr.tm00.nc" |
18 changes: 18 additions & 0 deletions
18
test/testinput/bufr_bufr4backend_sfcshp_prepbufr_mpi4.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| time window: | ||
| begin: "2021-07-31T21:00:00Z" | ||
| end: "2021-08-01T03:00:00Z" | ||
| bound to include: begin | ||
|
|
||
| observations: | ||
| - obs space: | ||
| name: "SFCSHP" | ||
| simulated variables: ['stationPressure','airTemperature','virtualTemperature','specificHumidity','windNorthward','windEastward'] | ||
| obsdatain: | ||
| engine: | ||
| type: bufr | ||
| obsfile: "./testdata/gdas.t00z.prepbufr" | ||
| mapping file: "./testinput/bufr_sfcshp_prepbufr_mapping.yaml" | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: "./testrun/bufr4backend/gdas.t00z.sfcshp_prepbufr.tm00_mpi4.nc" |
23 changes: 23 additions & 0 deletions
23
test/testinput/bufr_script4backend_acft_profiles_prepbufr.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| time window: | ||
| begin: "2021-07-31T21:00:00Z" | ||
| end: "2021-08-01T03:00:00Z" | ||
| bound to include: begin | ||
|
|
||
| observations: | ||
| - obs space: | ||
| name: "AIRCFT" | ||
| observed variables: ['airTemperature','specificHumidity','windNorthward','windEastward'] | ||
| derived variables: ['airTemperature','specificHumidity','windNorthward','windEastward'] | ||
| simulated variables: ['airTemperature','specificHumidity','windNorthward','windEastward'] | ||
| obsdatain: | ||
| engine: | ||
| type: script | ||
| script file: "./testinput/bufr_acft_profiles_prepbufr.py" | ||
| args: | ||
| input_path: "./testdata/gdas.t00z.prepbufr.acft_profiles" | ||
| mapping_path: "./testinput/bufr_acft_profiles_prepbufr_mapping.yaml" | ||
| cycle_time: "2021080100" | ||
| obsdataout: | ||
| engine: | ||
| type: H5File | ||
| obsfile: "./testrun/script4backend/gdas.t00z.acft_profiles_prepbufr.tm00.nc" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These codes (365-388) are exactly the same as the original one. Can we just add some if statement in the original function to handle this? If there are any other considerations just ignore of this comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are slightly different because one has the MPI count in it and the other does not, and there's not a way that I can see to combine them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean 53-76 vs 365-388.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When Emily and I were determining what we wanted to do, we decided to keep thing somewhat separate between data types. @emilyhcliu do you think this is something we should pursue?