Add CI tests for shared CCPP-physics and MOM6 submodule hash consistency#4594
Draft
Add CI tests for shared CCPP-physics and MOM6 submodule hash consistency#4594
Conversation
Co-authored-by: DavidHuber-NOAA <[email protected]>
Copilot
AI
changed the title
[WIP] Add CI test to verify common MOM6 and CCPP-physics hashes
Add CI tests for shared CCPP-physics and MOM6 submodule hash consistency
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CCPP-physics is pinned in both UFS_Utils (
sorc/ufs_utils.fd/ccpp-physics) and ufs-weather-model (via UFSATM atsorc/ufs_model.fd/UFSATM/ccpp/physics). When these diverge, build inconsistencies occur silently. Similarly, GDASApp/SOCA uses MOM6 from ufs-weather-model via a symlink inbuild.sh; if that relationship breaks, the build fails without a clear CI signal.Changes
dev/ci/scripts/unittests/test_submodule_hashes.py(new): Two pytest tests:test_ccpp_physics_hashes_match— compares CCPP-physics commit hashes betweensorc/ufs_utils.fd/ccpp-physicsandsorc/ufs_model.fd/UFSATM/ccpp/physicsusinggit ls-tree; fails when they differtest_gdas_mom6_uses_ufs_model_mom6— verifiessorc/gdas.cd/build.shsymlinks MOM6 fromsorc/ufs_model.fd/MOM6-interface/MOM6and that path is a registered submodule in ufs-weather-model; fails if the symlink target drifts or MOM6 is movedBoth tests skip gracefully when required submodules are not initialized (e.g., minimal CI checkouts).
.github/workflows/ci_unit_tests.yaml: Extends the submodule init step to includeufs_utils.fd,gdas.cd, and the nestedufs_model.fd/UFSATMsubmodule so the new tests are fully exercised in CI.Resolves #4593
Type of change
Change characteristics
How has this been tested?
7395db572d57af1118b9b524e8f8cda4e1cced4cfor CCPP-physics in both repos)Checklist
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/ufs-community/ufs-weather-model/git/trees/7b637a8b7d8e96c503b1719affaa647dea7b2631/home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js(http block)noaa-nws-global-pds.s3.amazonaws.com/usr/bin/python python -m pytest dev/ci/scripts/unittests/ -v --ignore=dev/ci/scripts/unittests/test_setup.py --ignore=dev/ci/scripts/unittests/test_create_experiment.py /opt/pipx_bin/git credential.helpetr(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.