Generalize ARCH_CYC for single cycle or list of cycles#4585
Merged
DavidHuber-NOAA merged 18 commits intoNOAA-EMC:developfrom Feb 27, 2026
Merged
Generalize ARCH_CYC for single cycle or list of cycles#4585DavidHuber-NOAA merged 18 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA merged 18 commits intoNOAA-EMC:developfrom
Conversation
- Added Union and Tuple to typing imports - Added _normalize_arch_cyc helper method for DRY ARCH_CYC normalization - Refactored _arch_warm_start_increments with better validation and docstrings - Refactored _arch_warm_restart_ics with improved error handling and case-insensitive RUN matching - Replaced magic number 24 with HOURS_PER_DAY constant - Enhanced docstrings with complete parameter and return documentation - Improved variable names for clarity (cycle_hours, adjusted_cycle_hours) - Added comprehensive error handling with descriptive messages - Used .startswith() for more robust GDAS detection - All changes validated with tests Co-authored-by: RussTreadon-NOAA <[email protected]>
…hods Refactor archive methods for robustness and consistency
…_vars.py Co-authored-by: RussTreadon-NOAA <[email protected]>
…yc-usage Generalize ARCH_CYC to support multiple cycle hours
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
WCOSS2 and Ursa g-w CI Install WCOSS2 (Dogwood) All jobs in all g-w cases run on WCOSS2 (Dogwood) successfully ran to completion. The configuration for C96C48_ufshybatmDA was modified to set Ursa All jobs in all g-w CI cases run on Ursa successfully ran to completion. The Ursa C96C48_hybatmDA case was extended to run out to 2021122206 with |
Contributor
Author
|
Given acceptable results from g-w CI tests on WCOSS2 (Dogwood) and Ursa, this PR is ready for review. |
RussTreadon-NOAA
requested review from
DavidHuber-NOAA and
TravisElless-NOAA
as code owners
DavidHuber-NOAA
approved these changes
Feb 27, 2026
Contributor
|
Thank you for adding this capability @RussTreadon-NOAA! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generalize ARCH_CYC to work with either a single cycle (current behavior) or a list of cycles (new functionality)
Resolves #4565
Type of change
Change characteristics
How has this been tested?
Checklist