Skip to content

Change VarBC names for JEDI#4571

Draft
CoryMartin-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
CoryMartin-NOAA:feature/varbc
Draft

Change VarBC names for JEDI#4571
CoryMartin-NOAA wants to merge 2 commits intoNOAA-EMC:developfrom
CoryMartin-NOAA:feature/varbc

Conversation

@CoryMartin-NOAA
Copy link
Contributor

Description

This PR will change the names of VarBC files for JEDI atmospheric cycling. It also includes a small fix for .gitignore that was not caught in the last PR + removing of GSI bias files for the JEDI case in the analysis j2 template.

Related to Issue #4570

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES (If YES, please indicate to which system(s))
    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES (If YES, please add a link to any PRs that are pending.)

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant