Refactor job scripts to streamline configuration sourcing#4563
Draft
bbakernoaa wants to merge 1 commit intoNOAA-EMC:developfrom
Draft
Refactor job scripts to streamline configuration sourcing#4563bbakernoaa wants to merge 1 commit intoNOAA-EMC:developfrom
bbakernoaa wants to merge 1 commit intoNOAA-EMC:developfrom
Conversation
- Updated multiple job scripts to remove the `-c "base ..."` argument from the `jjob_header.sh` sourcing command, simplifying the invocation. - Added sourcing for specific configuration files (`config.base`, `config.<job_name>`) in each job script to ensure necessary variables are set. - Enhanced clarity and maintainability of job scripts by organizing configuration sourcing in a consistent manner across all affected scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors the initialization of several job scripts to standardize how configuration files are sourced. The main change is to remove the use of the
-cargument in thejjob_header.shscript and instead explicitly source each required config file within the job script itself. This makes the configuration sourcing more transparent and easier to manage.Standardization of configuration sourcing in job scripts:
-cargument from thesource "${HOMEgfs}/ush/jjob_header.sh"command in all affected job scripts, simplifying the call and decoupling config sourcing from the header script. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]config.baseand other job-specific configs (e.g.,config.gempak,config.wave_stat, etc.), immediately after sourcing the header script. This improves clarity and maintainability by making all required configuration files visible at the top of each script. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]Impacts #4550
Type of change
Change characteristics
How has this been tested?
Checklist