Skip to content

Refactor job scripts to streamline configuration sourcing#4563

Draft
bbakernoaa wants to merge 1 commit intoNOAA-EMC:developfrom
bbakernoaa:feature/source_configs_jjobs
Draft

Refactor job scripts to streamline configuration sourcing#4563
bbakernoaa wants to merge 1 commit intoNOAA-EMC:developfrom
bbakernoaa:feature/source_configs_jjobs

Conversation

@bbakernoaa
Copy link
Contributor

Description

This pull request refactors the initialization of several job scripts to standardize how configuration files are sourced. The main change is to remove the use of the -c argument in the jjob_header.sh script and instead explicitly source each required config file within the job script itself. This makes the configuration sourcing more transparent and easier to manage.

Standardization of configuration sourcing in job scripts:

Impacts #4550

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO (If YES, please indicate to which system(s))
    • GFS
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

- Updated multiple job scripts to remove the `-c "base ..."` argument from the `jjob_header.sh` sourcing command, simplifying the invocation.
- Added sourcing for specific configuration files (`config.base`, `config.<job_name>`) in each job script to ensure necessary variables are set.
- Enhanced clarity and maintainability of job scripts by organizing configuration sourcing in a consistent manner across all affected scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant