De-template COM declarations#4555
Merged
DavidHuber-NOAA merged 83 commits intoNOAA-EMC:developfrom Mar 2, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
Restarting tests on WCOSS2. |
DavidHuber-NOAA
added
the
CI-Wcoss2-Running
Contributor
Author
|
All tests passed on WCOSS2 except the |
emcbot
added
CI-Gaeac6-Ready
Contributor
Author
|
Gaea's gitlab runner seems to be down and Ursa's runner scripts seemed to crash. I will carry on the Ursa tests manually. |
Contributor
Author
|
All tests passed on WCOSS2: |
DavidHuber-NOAA
added
CI-Wcoss2-Passed
Contributor
TravisElless-NOAA
left a comment
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
I haven't tripped over these yet in my test, but probably need to update the $ENSMEM call in these places too?
Co-authored-by: Travis Elless <113720457+TravisElless-NOAA@users.noreply.github.com>
DavidHuber-NOAA
commented
Feb 27, 2026
emcbot
added
the
CI-Ursa-Passed
DavidHuber-NOAA
removed
CI-Ursa-Running (CM)
TravisElless-NOAA
approved these changes
Mar 2, 2026
Contributor
TravisElless-NOAA
left a comment
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Things look good to me. An 80 member atm test passed successfully.
Contributor
Author
|
I will go ahead and merge this then. I will set up an 80-member fully-coupled test afterwards just to test all of the bells and whistles and address any additional issues if needed before opening a GFS v17 PR. |
DavidHuber-NOAA
added a commit
to DavidHuber-NOAA/global-workflow
that referenced
this pull request
Mar 2, 2026
12 tasks
DavidHuber-NOAA
added a commit
that referenced
this pull request
Mar 2, 2026
This de-templates COM declarations in GCAFS by cherry-picking PR #4555.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes all calls to
declare_from_tmpland makes allCOMdeclarations explicit. It also adds a utility that can be used to de-template COM declarations.Resolves #4522
Type of change
Change characteristics
How has this been tested?
All cases passed on C6. Further testing on other platforms will commence shortly.
Checklist