De-template COM declarations#4555
Open
DavidHuber-NOAA wants to merge 83 commits intoNOAA-EMC:developfrom
Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
I'm trying to build an experiment with this branch now and setup_workflow.py is breaking. Looks like there are some templated variables in dev/workflow/rocoto/gfs_tasks.py that need to be de-templified as well. |
DavidHuber-NOAA
removed
the
CI-Wcoss2-Running
Collaborator
|
@TravisElless-NOAA There is an error analysis report posted above that might help with some of those templated variable issues. |
dev/jobs/JGLOBAL_FORECAST
Outdated
Comment on lines
43
to
45
| if [[ 10#${ENSMEM:--1} -ge 0 ]]; then | ||
| # Turn ensmem into 3-digit format with leading zeros | ||
| memdir=$(printf "mem%03i" "${ENSMEM}") |
Contributor
There was a problem hiding this comment.
This is failing for ensemble members 8&9 with the following error message.
line 45: printf: 008: invalid octal number
Contributor
There was a problem hiding this comment.
You might need that 10# in front of ${ENSMEM}
Contributor
Author
There was a problem hiding this comment.
@TravisElless-NOAA @CoryMartin-NOAA I think this is fixed now. I successfully reran an enkfgdas_fcst job for member 1.
Travis, could you try rerunning your test case now?
Contributor
There was a problem hiding this comment.
It's working correctly for mem 9 in the forecast job now. Thanks @DavidHuber-NOAA!
Contributor
Author
|
Restarting tests on WCOSS2. |
DavidHuber-NOAA
added
the
CI-Wcoss2-Running
Contributor
Author
|
All tests passed on WCOSS2 except the |
emcbot
added
CI-Gaeac6-Ready
Contributor
Author
|
Gaea's gitlab runner seems to be down and Ursa's runner scripts seemed to crash. I will carry on the Ursa tests manually. |
Contributor
Author
|
All tests passed on WCOSS2: |
DavidHuber-NOAA
added
CI-Wcoss2-Passed
Contributor
TravisElless-NOAA
left a comment
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
I haven't tripped over these yet in my test, but probably need to update the $ENSMEM call in these places too?
Co-authored-by: Travis Elless <[email protected]>
DavidHuber-NOAA
commented
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes all calls to
declare_from_tmpland makes allCOMdeclarations explicit. It also adds a utility that can be used to de-template COM declarations.Resolves #4522
Type of change
Change characteristics
How has this been tested?
All cases passed on C6. Further testing on other platforms will commence shortly.
Checklist