Skip to content

Fix GDAS group b warm restart archiving#4503

Merged
DavidHuber-NOAA merged 5 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:fix/arch_warm
Feb 6, 2026
Merged

Fix GDAS group b warm restart archiving#4503
DavidHuber-NOAA merged 5 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:fix/arch_warm

Conversation

@DavidHuber-NOAA
Copy link
Contributor

Description

This fixes the GDAS-cycle warm restart archiving for group b (previous cycle) by adding assim_freq to the current cycle when checking the number of days since SDATE. This is a companion PR to #4502, which fixes the same issue in the dev/gfs.v17 branch.

Resolves #4501 for develop

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs YES
    • GFS (warm restarts)
    • GEFS
    • SFS
    • GCAFS
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Will test warm restart capability

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

@DavidHuber-NOAA
Copy link
Contributor Author

I have finished testing this case. The resulting archives were identical to those reported in #4502 (here). Here are the restart listings for cycles 2021122218 and 2021122300:

/NCEPDEV/emc-global/1year/David.Huber/URSA/scratch/C96C48mx500_S2SW_cyc_gfs_restart_warm_dev/2021122218:
enkfgdas_restartb_grp1.tar
gdasocean_analysis.tar
gdasocean_restart.tar
gdaswave_restart.tar
gdas_restartb.tar

/NCEPDEV/emc-global/1year/David.Huber/URSA/scratch/C96C48mx500_S2SW_cyc_gfs_restart_warm_dev/2021122300:
gdasice_restart.tar
enkfgdas_restarta_grp1.tar
gdasocean_analysis.tar
gfs_restarta.tar
gdas_restarta.tar

@DavidHuber-NOAA DavidHuber-NOAA marked this pull request as ready for review February 3, 2026 13:44
@emcbot emcbot added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress labels Feb 3, 2026
@DavidHuber-NOAA DavidHuber-NOAA removed the CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully label Feb 4, 2026
Copy link
Contributor

@TravisElless-NOAA TravisElless-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes match #4502 approved/merged changes

@DavidHuber-NOAA
Copy link
Contributor Author

Launching CI on C6. Once complete, I will check the restarts for the C96C48mx500_S2SW_cyc_gfs case.

@emcbot emcbot added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress labels Feb 5, 2026
@DavidHuber-NOAA
Copy link
Contributor Author

Verified that a full restart set was written for cycles 2021122018 (restart group b) and 2021122100 (restart group a) for the C96C48mx500_S2SW_cyc_gfs test case on C6:

/NCEPDEV/emc-global/1year/role.glopara/GAEAC6/scratch/C96C48mx500_S2SW_cyc_gfs_f87e24bd-8350/2021122018:
enkfgdas.tar                 gdas.tar                     gdaswave.tar                 gfs_netcdfb.tar              gfswave.tar                  
enkfgdas_grp1.tar            gdas_restartb.tar            gdaswave_restart.tar         gfs_pgrb2b.tar               ice_6hravg.tar               
enkfgdas_restartb_grp1.tar   gdasice.tar                  gfs_flux.tar                 gfsa.tar                     ice_native_subset.tar        
enkfgfs.tar                  gdasocean.tar                gfs_flux_1p00.tar            gfsb.tar                     ocean_6hravg.tar             
enkfgfs_grp1.tar             gdasocean_analysis.tar       gfs_netcdfa.tar              gfsocean_analysis.tar        ocean_native_subset.tar      
expdir.tar                   gdasocean_restart.tar

/NCEPDEV/emc-global/1year/role.glopara/GAEAC6/scratch/C96C48mx500_S2SW_cyc_gfs_f87e24bd-8350/2021122100:
enkfgdas.tar                 gdas.tar                     gdaswave.tar                 gfs_pgrb2b.tar               gfswave.tar                  
enkfgdas_grp1.tar            gdas_restarta.tar            gfs_flux.tar                 gfs_restarta.tar             ice_6hravg.tar               
enkfgdas_restarta_grp1.tar   gdasice.tar                  gfs_flux_1p00.tar            gfsa.tar                     ice_native_subset.tar        
enkfgfs.tar                  gdasice_restart.tar          gfs_netcdfa.tar              gfsb.tar                     ocean_6hravg.tar             
enkfgfs_grp1.tar             gdasocean.tar                gfs_netcdfb.tar              gfsocean_analysis.tar        ocean_native_subset.tar      
expdir.tar                   gdasocean_analysis.tar

@DavidHuber-NOAA DavidHuber-NOAA merged commit b3cf121 into NOAA-EMC:develop Feb 6, 2026
5 checks passed
@DavidHuber-NOAA DavidHuber-NOAA deleted the fix/arch_warm branch February 9, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issues with restart archiving

3 participants