Skip to content

Update wxflow submodule to include improved logit decorating#4496

Merged
DavidHuber-NOAA merged 2 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:feature/logit_fname
Jan 30, 2026
Merged

Update wxflow submodule to include improved logit decorating#4496
DavidHuber-NOAA merged 2 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:feature/logit_fname

Conversation

@DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Jan 30, 2026

Description

The improved functionality includes full paths to logit decorated function's housing module. This will help with debugging any issues in the Python modules.

Resolves #4493

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

Tested in the global workflow for a C48_ATM case and noted the following lines during the execution of gfs_arch_tar_gfsa:

+ JGLOBAL_ARCHIVE_TARS[86]/scratch3/NCEPDEV/global/David.Huber/GW/gw_logit_fname/scripts/exglobal_archive_tars.py
^[[38;21m2026-01-30 15:10:16,882 - INFO     - root        : BEGIN: __main__.main: /scratch3/NCEPDEV/global/David.Huber/GW/gw_logit_fname/scripts/exglobal_archive_tars.py^[[0m
^[[38;5;39m2026-01-30 15:10:16,882 - DEBUG    - root        : (  )^[[0m
^[[38;21m2026-01-30 15:10:16,887 - INFO     - archive     : BEGIN: Archive.__init__: /scratch3/NCEPDEV/global/David.Huber/GW/gw_logit_fname/ush/python/pygfs/task/archive.py^[[0m
...
^[[38;21m2026-01-30 15:10:16,892 - INFO     - archive_tar_vars: BEGIN: pygfs.utils.archive_tar_vars._get_all_cyc_vars: /scratch3/NCEPDEV/global/David.Huber/GW/gw_logit_fname/ush/python/pygfs/utils/archive_tar_vars.py^[[0m

Full paths are written each time a function is called that has a logit decorator. The C48_ATM case ran to completion. Altogether there were 21 such decorations made to the log file showing that the use is likely not overly impactful on runtime. All arch_tar* jobs (5 in total) ran in less than 40 seconds.

The gfs_stage_ic job also showed these decorations and executed in 13 seconds.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

@DavidHuber-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA DavidHuber-NOAA merged commit 7b6a8d0 into NOAA-EMC:develop Jan 30, 2026
5 checks passed
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/logit_fname branch February 4, 2026 12:38
CoryMartin-NOAA pushed a commit to CoryMartin-NOAA/global-workflow that referenced this pull request Feb 25, 2026
…EMC#4496)

The improved functionality includes full paths to `logit` decorated
function's housing module. This will help with debugging any issues in
the Python modules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve python logging

3 participants