Skip to content

Make metp jobs run in parallel#4478

Merged
DavidHuber-NOAA merged 2 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:feature/parallel_metp
Jan 28, 2026
Merged

Make metp jobs run in parallel#4478
DavidHuber-NOAA merged 2 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA:feature/parallel_metp

Conversation

@DavidHuber-NOAA
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA commented Jan 27, 2026

Description

This adds the capability to run the metplus jobs in parallel by applying a bugfix to the J-Job.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Will test CI on WCOSS2

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

@DavidHuber-NOAA
Copy link
Contributor Author

Running tests on Dogwood.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress label Jan 27, 2026
@DavidHuber-NOAA
Copy link
Contributor Author

All tests passed on WCOSS2 and all metp* jobs ran on the first call. Statistics were also generated for most cases. It is worth noting that statistics were not generated for the C48_S2SW_extended, C96C48_hybatmsnowDA, and C96C48_hybatmsoilDA cases. There is a bug in verif-global that currently causes one-cycle (non-00Z) statistics generation. This is being fixed in NOAA-EMC/EMC_verif-global#200 and #4455 (along with other upgrades/fixes). This PR only addresses the capability of running metp jobs in parallel.

@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Jan 28, 2026
@DavidHuber-NOAA
Copy link
Contributor Author

This PR is now ready for review.

Copy link
Contributor

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me.

I poked around in your test directories and things look as expected: I see your XML file now has mode="parallel", it looks like all 3 metp jobs started around the same time, and the $DATA directories are cleaned appropriately. Thanks @DavidHuber-NOAA!

@DavidHuber-NOAA DavidHuber-NOAA merged commit 8c762dd into NOAA-EMC:develop Jan 28, 2026
5 checks passed
DavidHuber-NOAA pushed a commit that referenced this pull request Jan 29, 2026
This is cherry-picking updates from @DavidHuber-NOAA to the dev/gfsv17
branch. The orginal PR: #4478
@DavidHuber-NOAA DavidHuber-NOAA deleted the feature/parallel_metp branch February 4, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants