Update GCAFS dev branch to match develop#4445
Merged
CoryMartin-NOAA merged 7 commits intoNOAA-EMC:dev/gcafs.v1from Jan 15, 2026
Merged
Update GCAFS dev branch to match develop#4445CoryMartin-NOAA merged 7 commits intoNOAA-EMC:dev/gcafs.v1from
CoryMartin-NOAA merged 7 commits intoNOAA-EMC:dev/gcafs.v1from
Conversation
This just updates the README to update the support levels for different platforms. I dropped comments about METplus verification as it is not supported anywhere at the moment except on WCOSS2.
# Description This moves the `C96mx025_S2S` test case from the PR matrix to the `sfsv1` directory so it can still be run but not for every PR. Resolves NOAA-EMC#4429 # Type of change - [ ] Bug fix (fixes something broken) - [ ] New feature (adds functionality) - [x] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics - Is this change expected to change outputs NO - Is this a breaking change (a change in existing functionality)? YES the high res S2S case will no longer run in CI (by design) - Does this change require a documentation update? NO - Does this change require an update to any of the following submodules? NO # How has this been tested? Successfully launched the `C96mx025_S2S` test case on C6 using `generate_workflows.sh`: ```bash ./generate_workflows.sh -Y ../ci/cases/sfsv1 -y C96mx025_S2S /gpfs/f6/drsa-precip4/scratch/David.Huber/test_sfs ``` and verified the test still ran through the first forecast segment. # Checklist - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code - [x] I have documented my code, including function, input, and output descriptions - [x] My changes generate no new warnings - [x] New and existing tests pass with my changes - [x] This change is covered by an existing CI test or a new one has been added
# Description This PR fixes a problem whereby the JEDI LETKF solver job, `atmensanlsol`, attempts to process observation inputs that don't exist. With these changes, the input YAML for the `atmensanlsol` JEDI application is rendered after the LETKF observer job, `atmensanlobs`, runs, and the rendering is performed using the `clean_empty_obsspaces` option in the `initialize()` method of the `Jedi` class. This ensures that the observation inputs that the solver needs, produced by the observer, are present before initialization, so that missing observation inputs can be removed using the `clean_empty_obsspaces` option. Resolves NOAA-EMC#4420 # Type of change - [X] Bug fix (fixes something broken) - [ ] New feature (adds functionality) - [ ] Maintenance (code refactor, clean-up, new CI test, etc.) # Change characteristics <!-- Choose YES or NO from each of the following and delete the other --> - Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO (If YES, please indicate to which system(s)) - [ ] GFS - [ ] GEFS - [ ] SFS - [ ] GCAFS - Is this a breaking change (a change in existing functionality)? YES/NO - Does this change require a documentation update? YES/NO - Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.) - [ ] EMC verif-global <!-- NOAA-EMC/EMC_verif-global#1234 --> - [ ] GDAS <!-- NOAA-EMC/GDASApp#1234 --> - [ ] GFS-utils <!-- NOAA-EMC/gfs-utils#1234 --> - [ ] GSI <!-- NOAA-EMC/GSI#1234 --> - [ ] GSI-monitor <!-- NOAA-EMC/GSI-Monitor#1234 --> - [ ] GSI-utils <!-- NOAA-EMC/GSI-Utils#1234 --> - [ ] UFS-utils <!-- ufs-community/UFS_UTILS#1234 --> - [ ] UFS-weather-model <!-- ufs-community/ufs-weather-model#1234 --> - [ ] wxflow <!-- NOAA-EMC/wxflow#1234 --> # How has this been tested? # Checklist - [X] Any dependent changes have been merged and published - [X] My code follows the style guidelines of this project - [X] I have performed a self-review of my own code - [X] I have commented my code, particularly in hard-to-understand areas - [ ] I have documented my code, including function, input, and output descriptions - [ ] My changes generate no new warnings - [ ] New and existing tests pass with my changes - [X] This change is covered by an existing CI test or a new one has been added - [ ] Any new scripts have been added to the .github/CODEOWNERS file with owners - [ ] I have made corresponding changes to the system documentation if necessary
This adds support for the GCAFS tests on Ursa. Resolves NOAA-EMC#3976
# Description (This is a re-opening of NOAA-EMC#4382) Fixes some issues from the recent expansion of bash code analysis and switch to the reviewdog framework. First and foremost, the permission issue that prevented errors from being posted to the PR are fixed. This was only an issue for pull requests from forks (which is all of them for us). The trigger is changed to `pull_request_target`, which changes the context to the target repo. This is safe as long as we are not attempting to build or run the code. Because of the context change, an additional argument is needed for checkout to checkout the head of the PR. Second, some parameters are turned into conditionals to handle the fact that the action is run on both pull requests and merges to develop. This allows both the correct hash in the previous change, and also the correct GH reporter to be used. This uses a new GH action that will need to be added to the allowed list. Third, the `shfmt` options are fixed so that it actually fails on error. Reviewdog has deprecated `fail_on_error`, but the `reviewdog/shfmt` action does not seem to support the replacement `fail_level`. So, `fail_level` is passed to reviewdog directly as a flag. Finally, the README status badges are updated for the new actions. Additionally, clicking on the code analysis badges now brings up the GH action logs. Note: the `bash_code_analysis` actions may not run for this PR because of the trigger change. It will run on develop after merge, and on PRs from then on. Resolves NOAA-EMC#4369
# Description This PR is a hotfix for NOAA-EMC#4439
CoryMartin-NOAA
requested review from
DavidHuber-NOAA,
DavidNew-NOAA,
RussTreadon-NOAA,
TerrenceMcGuinness-NOAA and
aerorahul
as code owners
bbakernoaa
reviewed
Jan 15, 2026
| skip_ci_on_hosts: | ||
| - gaeac5 | ||
| - awsepicglobalworkflow | ||
| - ursa |
Contributor
There was a problem hiding this comment.
should we run this on Ursa now that its running well?
Contributor
Author
There was a problem hiding this comment.
That's what this does, removes Ursa from the 'skip' list
bbakernoaa
reviewed
Jan 15, 2026
| - gaeac5 | ||
| - hercules | ||
| - awsepicglobalworkflow | ||
| - ursa |
bbakernoaa
reviewed
Jan 15, 2026
| - X | ||
| - X | ||
| - | ||
| - x |
Contributor
There was a problem hiding this comment.
should this be uppercase?
Contributor
Author
There was a problem hiding this comment.
no idea, it's whatever is in develop now
Contributor
There was a problem hiding this comment.
It should be. I'll fix this in develop on my next PR.
bbakernoaa
approved these changes
Jan 15, 2026
Contributor
bbakernoaa
left a comment
bbakernoaa
left a comment
There was a problem hiding this comment.
just a few comments. but take them or leave them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bring in develop changes to GCAFSv1 dev branch. No results are changed but it should be done to include Ursa support for CI tests.
Type of change
Change characteristics
Checklist