Skip to content

Modify formating for xml dependency#4367

Merged
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
RussTreadon-NOAA:bugfix/dependency
Dec 23, 2025
Merged

Modify formating for xml dependency#4367
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
RussTreadon-NOAA:bugfix/dependency

Conversation

@RussTreadon-NOAA
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Dec 21, 2025 •
edited
Loading

Description

github copilot was used to troubleshoot the problem described in issue #4366. This PR contains copilot generated changes to rocoto.py which remove the extraneous \t characters in the metpg dependency included for task gfs_cleanup.

Resolves #4366

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

Run GDASApp ctests including select g-w CI on Hera. All 137 tests Passed.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Dec 21, 2025
@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review December 21, 2025 23:44
@RussTreadon-NOAA
Copy link
Contributor Author

RussTreadon-NOAA commented Dec 22, 2025

Hera g-w CI

Install RussTreadon-NOAA:bugfix/dependency at f67d19e on Hera. Updated sorc/gdas.cd to feature/stable-nightly at 89fd3dc. GDASApp PR #2013 will merge this hash into GDASApp develop

Run g-w CI on Hera with the following results

 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48_ATM_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Dec 21 2025 23:55:10    Dec 22 2025 01:00:15
 
SKIP C48_ATM_ecflow on hera
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48_S2SW_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Dec 21 2025 23:55:12    Dec 22 2025 01:05:13
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48_S2SWA_gefs_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103231200        Done    Dec 21 2025 23:55:11    Dec 22 2025 01:30:16
 
SKIP C48_S2SWA_gefs_RT on hera
 
SKIP C48_S2SW_extended on hera
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48mx500_3DVarAOWCDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Dec 21 2025 23:55:14    Dec 22 2025 01:35:14
202103250000        Done    Dec 21 2025 23:55:14    Dec 22 2025 02:05:13
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C48mx500_hybAOWCDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202103241800        Done    Dec 21 2025 23:55:15    Dec 22 2025 00:25:15
202103250000        Done    Dec 21 2025 23:55:15    Dec 22 2025 01:50:18
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_hybatmDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Dec 21 2025 23:55:16    Dec 22 2025 00:25:16
202112210000        Done    Dec 21 2025 23:55:16    Dec 22 2025 02:50:17
202112210600        Done    Dec 21 2025 23:55:16    Dec 22 2025 02:35:16
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_hybatmsnowDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Dec 21 2025 23:55:18    Dec 22 2025 00:30:26
202112201800        Done    Dec 21 2025 23:55:18    Dec 22 2025 02:50:18
202112210000        Done    Dec 21 2025 23:55:18    Dec 22 2025 02:50:18
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_hybatmsoilDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202205150600        Done    Dec 21 2025 23:55:19    Dec 22 2025 00:30:28
202205151200        Done    Dec 21 2025 23:55:19    Dec 22 2025 02:55:19
202205151800        Done    Dec 21 2025 23:55:19    Dec 22 2025 02:55:19
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_ufs_hybatmDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    Dec 21 2025 23:55:20    Dec 22 2025 00:30:29
202402240000        Done    Dec 21 2025 23:55:20    Dec 22 2025 03:10:20
202402240600        Done    Dec 21 2025 23:55:20    Dec 22 2025 02:55:20
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48_ufsgsi_hybatmDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202402231800        Done    Dec 21 2025 23:55:22    Dec 22 2025 00:30:31
202402240000        Done    Dec 21 2025 23:55:22    Dec 22 2025 03:15:26
202402240600        Done    Dec 21 2025 23:55:22    Dec 22 2025 02:55:21
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96C48mx500_S2SW_cyc_gfs_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Dec 21 2025 23:55:23    Dec 22 2025 02:10:24
202112201800        Done    Dec 21 2025 23:55:23    Dec 22 2025 03:25:22
202112210000        Done    Dec 21 2025 23:55:23    Dec 22 2025 03:50:24
202112211800        Done    Dec 22 2025 02:15:30    Dec 22 2025 04:00:33
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96_atm3DVar_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201800        Done    Dec 21 2025 23:55:24    Dec 22 2025 00:35:24
202112210000        Done    Dec 21 2025 23:55:24    Dec 22 2025 03:00:36
202112210600        Done    Dec 21 2025 23:55:24    Dec 22 2025 03:05:25
 
SKIP C96_atm3DVar_extended on hera
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96_gcafs_cycled_bugfix
202112201200       gcdas_aeroanlgenb                    20220686                DEAD                  15         2          38.0        -          
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96_gcafs_cycled_noDA_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
202112201200        Done    Dec 21 2025 23:55:25    Dec 22 2025 00:30:36
202112201800        Done    Dec 21 2025 23:55:25    Dec 22 2025 02:25:26
202112210000        Done    Dec 21 2025 23:55:25    Dec 22 2025 01:30:39
 
/scratch3/NCEPDEV/stmp/Russ.Treadon/EXPDIR/C96mx100_S2S_bugfix
   CYCLE         STATE           ACTIVATED              DEACTIVATED     
199405010000        Done    Dec 21 2025 23:55:28    Dec 22 2025 01:30:42

All cycles for all cases ran to completion except C96_gcafs_cycled. The gcdas_aeroanlgenb failure is a known problem. The failure will persist until g-w issue #4295 is closed.

Examination of the xml files created for each case do not find any occurrences of the string \t.

NOTE
We can NOT build GDASApp on compute nodes starting with GDASApp develop at ab8fadd. See GDASApp issue #2016 for details. Moving to GDASApp feature/stable-nightly does not resolve this problem.

g-w sorc/gdas.cd was updated to gdas.cd @ ab8fadd via g-w PR #4306.

Tagging @DavidHuber-NOAA , @aerorahul , and @DavidNew-NOAA for awareness.

@DavidHuber-NOAA
Copy link
Contributor

DavidHuber-NOAA commented Dec 22, 2025

Thank you for catching/fixing my slop @RussTreadon-NOAA. I should have tested #4305 on WCOSS2.

I will review this PR and test it on WCOSS2 today.

DavidHuber-NOAA
DavidHuber-NOAA previously approved these changes Dec 22, 2025
View reviewed changes
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one suggestion on a comment.

@DavidHuber-NOAA
Copy link
Contributor

DavidHuber-NOAA commented Dec 22, 2025

Launching CI on WCOSS2.

I will also verify that the XMLs render as expected.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress label Dec 22, 2025
aerorahul
aerorahul previously approved these changes Dec 22, 2025
View reviewed changes
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Dec 22, 2025
Closed
@DavidHuber-NOAA DavidHuber-NOAA mentioned this pull request Dec 22, 2025
Open
@DavidHuber-NOAA
Copy link
Contributor

DavidHuber-NOAA commented Dec 23, 2025

All tests passed on WCOSS2 except for C96_atm3DVar_extended and C96_gcafs_cycled_4367, which both failed due to known issues. I have also looked at the XML structure, which does differ from develop by introducing a flattened structure, but I am OK with this. For example, C96_atm3DVar_extended.xml now contains the following dependency tree for gfs_prep:

    <dependency>
        <and>
        <metataskdep metatask="gdas_atmos_prod" cycle_offset="-06:00:00"/>
        <datadep><cyclestr offset="-06:00:00">&ROTDIR;/gdas.@Y@m@d/@H//model/atmos/history/[email protected]</cyclestr></datadep>
        <datadep><cyclestr>/lfs/h2/emc/dump/noscrub/dump/gfs.@Y@m@d/@H/atmos/[email protected]_d</cyclestr></datadep>
        <metataskdep metatask="gdas_fcst" cycle_offset="-06:00:00"/>
        </and>
    </dependency>

If it is desired to re-introduce tabbing for nested <and> <or> .... </or> </and> dependency trees, a followup issue can be opened to determine feasibility. Merging this as is.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 05909e9 into NOAA-EMC:develop Dec 23, 2025
5 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the bugfix/dependency branch January 12, 2026 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidHuber-NOAA DavidHuber-NOAA DavidHuber-NOAA approved these changes

@aerorahul aerorahul aerorahul left review comments

Assignees

@RussTreadon-NOAA RussTreadon-NOAA

Labels

CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

g-w CI xml files contain string "\t" in metpg dependency for gfs_cleanup

3 participants

@RussTreadon-NOAA @DavidHuber-NOAA @aerorahul