Remove remaining calls to routines in marine_da_utils.py#4356
Merged
TravisElless-NOAA merged 16 commits intoNOAA-EMC:developfrom Jan 6, 2026
Merged
Remove remaining calls to routines in marine_da_utils.py#4356TravisElless-NOAA merged 16 commits intoNOAA-EMC:developfrom
TravisElless-NOAA merged 16 commits intoNOAA-EMC:developfrom
Conversation
Contributor
Author
|
@aerorahul @DavidHuber-NOAA This PR is ready for review |
TravisElless-NOAA
previously approved these changes
Jan 6, 2026
Contributor
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Things look alright to me. Approve pending testing. Will launch CI on Ursa
aerorahul
reviewed
Jan 6, 2026
aerorahul
previously approved these changes
Jan 6, 2026
Contributor
aerorahul
left a comment
There was a problem hiding this comment.
looks good. thanks. Just one suggestion to pop out the relevant error information in the traceback
71a9f2c
TravisElless-NOAA
approved these changes
Jan 6, 2026
Contributor
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
CI Passed. Merging
Contributor
Author
|
Thanks @TravisElless-NOAA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes calls to legacy routines in
ush/python/pygfs/utils/marine_da_utils.py. Most of these calls were removed in previous PRs, and this one cleans up the remainder.The code in
get_mom6_levels()was moved into theAnalysisclass constructor and , so the number of mom6 levels becomes part oftask_config, available for all marine tasks.prep_input_yaml()is replaced by simply creating two.nml.j2templates in GDASApp (rather than one) and invoking the newparse_j2tmplfromwxflow.gen_bkg_list()was only called once inush/python/pygfs/task/marine_analysis.py, so I moved its code into the constructor for theMarineAnalysistask.test_hist_date()was only called inush/python/pygfs/task/marine_analysis.py, so I made it a static method of theMarineAnalysistask.run()is moved into theAnalysisclass.Resolves #4355
Type of change
Change characteristics
How has this been tested?
Clone, build, and CI on Hera
Checklist