Skip to content

copy/link abias_int to satbias_in in the eupd run directory#4332

Merged
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
RussTreadon-NOAA:feature/abiase
Dec 16, 2025
Merged

copy/link abias_int to satbias_in in the eupd run directory#4332
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
RussTreadon-NOAA:feature/abiase

Conversation

@RussTreadon-NOAA
Copy link
Contributor

Description

This PR links abias_int to satbias_in in the eupd run directory.

Resolves #4331

Type of change

  • Bug fix (fixes something broken)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES
    • GFS
    • GEFS
    • SFS
    • GCAFS

This PR alters ensemble analysis increments generated by the eupd job if radiances from satellites besides amsua and atms are assimilated. I do not know if GEFS, SFS, or GCAFS cycling runs with eupd.

  • Is this a breaking change (a change in existing functionality)? NO

  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Clone, build, and install in GFS v17 GSI and JEDI parallels running on WCOSS2 (Cactus)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added

@DavidHuber-NOAA
Copy link
Contributor

Launching tests on C6.

@emcbot emcbot added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 labels Dec 15, 2025
@DavidHuber-NOAA
Copy link
Contributor

I will incorporate d42c6d6 into the C6 test.

@emcbot emcbot added CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress and removed CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 labels Dec 15, 2025
@RussTreadon-NOAA RussTreadon-NOAA self-assigned this Dec 15, 2025
@emcbot
Copy link

emcbot commented Dec 15, 2025

C96_gcafs_cycled_noDA FAILED on Gaeac6 (pipeline ID: 6358)

In directory: /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4332_be51ea02_6358/RUNTESTS/EXPDIR/C96_gcafs_cycled_noDA_be51ea02-6358

Error Log Files:


/gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4332_be51ea02_6358/RUNTESTS/COMROOT/C96_gcafs_cycled_noDA_be51ea02-6358/logs/2021122018/gcafs_arch_tars.log

View Error Logs: (gcafs_arch_tars.log)

This failure was detected automatically by global-workflow's CI/CD Pipeline

@emcbot emcbot added CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed and removed CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress labels Dec 15, 2025
@emcbot
Copy link

emcbot commented Dec 15, 2025

C96_gcafs_cycled FAILED on Gaeac6 (pipeline ID: 6358)

In directory: /gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4332_be51ea02_6358/RUNTESTS/EXPDIR/C96_gcafs_cycled_be51ea02-6358

Error Log Files:


/gpfs/f6/drsa-precip3/world-shared/global/CI/GITLAB/pr_cases_4332_be51ea02_6358/RUNTESTS/COMROOT/C96_gcafs_cycled_be51ea02-6358/logs/2021122018/gcafs_arch_tars.log

View Error Logs: (gcafs_arch_tars.log)

This failure was detected automatically by global-workflow's CI/CD Pipeline

@RussTreadon-NOAA
Copy link
Contributor Author

The GCAFS failures appear to be due to a disconnect between the archive job and changes added by PR #4147.

PR #4147 changed downset=2 to downset=1 in dev/parm/config/gcafs/config.atmos_products. This change appears to turn off generation of pres_b files.

parm/archive/master_gcafs.yaml.j2 contains the following in a required section

            {% endfor %}
            {% if ARCH_GAUSSIAN %}
            {% for fhr in range(0, FHMAX_GFS + FHOUT_GFS, FHOUT_GFS) %}
            - "{{ COMIN_ATMOS_GRIB_0p25 | relpath(ROTDIR) }}/{{ head }}pres_b.0p25.f{{ '%03d' % fhr }}.grib2"
            - "{{ COMIN_ATMOS_GRIB_0p25 | relpath(ROTDIR) }}/{{ head }}pres_b.0p25.f{{ '%03d' % fhr }}.grib2.idx"
            - "{{ COMIN_ATMOS_GRIB_1p00 | relpath(ROTDIR) }}/{{ head }}pres_b.1p00.f{{ '%03d' % fhr }}.grib2"
            - "{{ COMIN_ATMOS_GRIB_1p00 | relpath(ROTDIR) }}/{{ head }}pres_b.1p00.f{{ '%03d' % fhr }}.grib2.idx"
            {% endfor %}
            {% endif %}

config.arch_tars for both C96_gcafs_cycled_noDA and 96_gcafs_cycled sets export ARCH_GAUSSIAN=YES. Thus, execution enters the pres_b block. The pres_b files were not generated by gcafs_atmos_prod jobs. Hence the failure.

Thank you @DavidHuber-NOAA for opening issue #4334. The same disconnect caused the Gaea C6 GCAFS failures.

@DavidHuber-NOAA
Copy link
Contributor

Marking this PR as passed (cm) on C6 as the only failures were from the known GCAFS archiving issue. Merging.

@DavidHuber-NOAA DavidHuber-NOAA added CI-Gaeac6-Passed (cm) Manual CI passed on Gaea C6 and removed CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed labels Dec 16, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit 5a3a320 into NOAA-EMC:develop Dec 16, 2025
6 checks passed
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/abiase branch December 16, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Gaeac6-Passed (cm) Manual CI passed on Gaea C6

Projects

None yet

Development

Successfully merging this pull request may close these issues.

exglobal_enkf_update.sh missing satbias_in

5 participants