Ensures any failure in piped output is captured and reported.#4328
Ensures any failure in piped output is captured and reported.#4328DavidHuber-NOAA merged 28 commits intoNOAA-EMC:developfrom
Conversation
…not found in the ufsgsi test
WalterKolczynski-NOAA
left a comment
There was a problem hiding this comment.
I'm worried that sometimes we want to ignore the pipefail (particularly when using grep with wgrib2).
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Just a couple of suggestions with find speedups. Otherwise, it looks good. I'm expecting a few more bugs to resolve as testing continues.
Thanks @WalterKolczynski-NOAA What do you think? |
Co-authored-by: David Huber <[email protected]> Co-authored-by: Travis Elless <[email protected]>
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me.
|
C96C48_hybatmDA FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48_hybatmsnowDA FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48_ufsgsi_hybatmDA FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48_hybatmsoilDA FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48mx500_hybAOWCDA FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96_atm3DVar FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48_ufs_hybatmDA FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48_S2SW FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gfs_atmos_prod_f000-f002.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48mx500_3DVarAOWCDA FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48mx500_S2SW_cyc_gfs FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96mx100_S2S FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (sfs_atmos_prod_mem000_f000.log) (sfs_atmos_prod_mem001_f000.log) (sfs_atmos_prod_mem002_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48_S2SW FAILED on Hercules (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gfs_atmos_prod_f000-f002.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48mx500_3DVarAOWCDA FAILED on Hercules (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48_S2SWA_gefs FAILED on Ursa (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gefs_atmos_prod_mem000_f000.log) (gefs_atmos_prod_mem001_f000.log) (gefs_atmos_prod_mem002_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96C48mx500_S2SW_cyc_gfs FAILED on Hercules (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gdas_atmos_prod_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C96mx100_S2S FAILED on Hercules (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (sfs_atmos_prod_mem000_f000.log) (sfs_atmos_prod_mem001_f000.log) (sfs_atmos_prod_mem002_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
C48_S2SWA_gefs FAILED on Hercules (pipeline ID: 6509) In directory: Error Log Files: View Error Logs: (gefs_atmos_prod_mem000_f000.log) (gefs_atmos_prod_mem001_f000.log) (gefs_atmos_prod_mem002_f000.log) This failure was detected automatically by global-workflow's CI/CD Pipeline |
|
The failures in the gcafs but not in gfs|gefs|sfs configs, and required for
.
|
|
Launching on Hercules and Ursa. |
|
@aerorahul @bbakernoaa is on AL today. Do you need me to open a bugfix PR for this or can those changes be incorporated here? |
|
Never mind I see that @DavidHuber-NOAA reverted the PR. @bbakernoaa let's get this fixed in develop first then when we are back, |
|
@DavidHuber-NOAA |
|
Turns out that Hercules never actually ran. The GitLab runner was killed at some point. Merging based on success on Ursa and WCOSS2. |
Description
This PR:
This PR also provides a hotfix for #4334
Type of change
Change characteristics
How has this been tested?
Checklist