Ensures any failure in piped output is captured and reported.

[aerorahul]

Description

This PR:

• Resolves Add set -o pipefail to set_strict #4263

This PR also provides a hotfix for #4334

• Fixes GCAFS Attempts to archive non-existent pres_b products #4334

Type of change

• Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

• Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
• Is this a breaking change (a change in existing functionality)? NO
• Does this change require a documentation update? NO
• Does this change require an update to any of the following submodules? NO

How has this been tested?

• GFS tests on GaeaC6 and WCOSS
• More testing is in progress

Checklist

• Any dependent changes have been merged and published
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have documented my code, including function, input, and output descriptions
• My changes generate no new warnings
• New and existing tests pass with my changes
• This change is covered by an existing CI test or a new one has been added
• Any new scripts have been added to the .github/CODEOWNERS file with owners
• I have made corresponding changes to the system documentation if necessary

[WalterKolczynski-NOAA]

I'm worried that sometimes we want to ignore the pipefail (particularly when using grep with wgrib2).

[DavidHuber-NOAA]

Just a couple of suggestions with find speedups. Otherwise, it looks good. I'm expecting a few more bugs to resolve as testing continues.

[aerorahul]

I'm worried that sometimes we want to ignore the pipefail (particularly when using grep with wgrib2).

Thanks @WalterKolczynski-NOAA
Do you know where that is the case presently? If we know, then we can wrap that call with unset_strict such that"

unset_strict
wgrib2 ....
set_strict

What do you think?

[DavidHuber-NOAA]

Looks good to me.

[DavidHuber-NOAA]

Launching on Hercules and Ursa.

[CoryMartin-NOAA]

@aerorahul @bbakernoaa is on AL today. Do you need me to open a bugfix PR for this or can those changes be incorporated here?

[CoryMartin-NOAA]

Never mind I see that @DavidHuber-NOAA reverted the PR. @bbakernoaa let's get this fixed in develop first then when we are back,

[aerorahul]

@DavidHuber-NOAA
I applied your suggestion to comment out the gcafs pres_b archiving. With that, hopefully develop will not fail on that account.

[DavidHuber-NOAA]

Turns out that Hercules never actually ran. The GitLab runner was killed at some point. Merging based on success on Ursa and WCOSS2.