Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
bc69895
Extend GDASApp to run atm JEDI EnVar DA with GSI EnKF (#4236)
RussTreadon-NOAA Nov 25, 2025
6fed11c
remove obsolete GDASApp logic from build_compute.sh (#4275) (#4276)
RussTreadon-NOAA Nov 25, 2025
add8922
Update bash ex-scripts to be linter compliant (#4151)
WalterKolczynski-NOAA Nov 26, 2025
51e848a
Add support for GCAFS on MSU HPC (#3844)
CoryMartin-NOAA Nov 26, 2025
76c5df5
Refactor Stage IC: Move COM and Cycle Variables and Logic from YAML M…
AntonMFernando-NOAA Dec 1, 2025
da19eb6
Update shell script analysis GH action (#4280)
WalterKolczynski-NOAA Dec 2, 2025
c76804b
Fix eobs diags being left on the floor and a number of EE2 related up…
aerorahul Dec 4, 2025
4ff8e19
Reduction in Ocean and Sea Ice Output (#4200)
NeilBarton-NOAA Dec 4, 2025
8ae8674
Update PR template for expected changes (#4278)
DavidHuber-NOAA Dec 5, 2025
b6604d0
Rename a bunch of jgdas/exgdas to jglobal/exglobal (#4293)
aerorahul Dec 5, 2025
a912381
Specify marine yamls for gfs ocean analysis archiving (#4286)
JohnSteffen-NOAA Dec 5, 2025
390f243
Move j-jobs and ex-scripts into dev subdirectory (#4259)
CoryMartin-NOAA Dec 8, 2025
9e1ae04
Generalize AWS config.resources for compute parition; add mem_node_ma…
TaylorRoper-NOAA Dec 8, 2025
cf7039a
Fix METplus dependency matrix (#4297)
DavidHuber-NOAA Dec 9, 2025
ebb5bae
point to release/gfs.v17 for gdas app
JessicaMeixner-NOAA Dec 9, 2025
b66a420
Reduce HPSS jobs' memory to 3GB on WCOSS2 (#4307)
DavidHuber-NOAA Dec 10, 2025
f5f96dc
Refactor cleanup task and add checks for gempak files (#4258)
DavidHuber-NOAA Dec 10, 2025
1624130
update gsi hash to include ABI G19 in build_gsinfo (issue #4287) (#4304)
jswhit Dec 10, 2025
70083a8
updates for ice in
JessicaMeixner-NOAA Dec 10, 2025
4474647
update model
JessicaMeixner-NOAA Dec 10, 2025
f2a34bf
Update ush scripts to comply with bash static code checkers (#4292)
WalterKolczynski-NOAA Dec 11, 2025
49812c7
Ensure minmon scripts do not fail silently (#4308)
EdwardSafford-NOAA Dec 11, 2025
8414673
Refactor Local Archiving: Move YAML Logic to archive_vars.py and Hand…
AntonMFernando-NOAA Dec 11, 2025
ebd2615
Add escape dependencies for *gdas cleanup jobs before the first gfs c…
DavidHuber-NOAA Dec 11, 2025
4e03e8a
Update noaacloud data paths to come from lustre mount linked to noaa-…
TaylorRoper-NOAA Dec 11, 2025
6e219a5
Merge remote-tracking branch 'EMC/develop' into updateufs122025
JessicaMeixner-NOAA Dec 11, 2025
2f753bb
Merge remote-tracking branch 'EMC/develop' into gfsv17/updateplusgdas
JessicaMeixner-NOAA Dec 11, 2025
f2fdc52
Merge remote-tracking branch 'origin/updateufs122025' into gfsv17/upd…
JessicaMeixner-NOAA Dec 12, 2025
ac94b9a
Update for ufs-weather-model (#4314)
JessicaMeixner-NOAA Dec 12, 2025
b0f96b9
Merge remote-tracking branch 'EMC/develop' into gfsv17/updateplusgdas
JessicaMeixner-NOAA Dec 12, 2025
2c767b3
update gdasapp hash
JessicaMeixner-NOAA Dec 12, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ indent_style = tab
indent_size = 4
max_line_length = 79

[jobs/*]
[dev/jobs/*]
indent_style = space
indent_size = 4
shell_variant = bash
Expand Down
3 changes: 1 addition & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ jobs/JGLOBAL_MARINE_* @guillaumevernieres @AndrewEichmann-NOAA
jobs/JGLOBAL_OCEANICE_PRODUCTS @JesseMeng-NOAA @ChristopherHill-NOAA
jobs/JGLOBAL_OFFLINE_ATMOS_ANALYSIS @CoryMartin-NOAA
jobs/JGLOBAL_PREP_EMISSIONS @bbakernoaa
jobs/JGLOBAL_PREP_OBS_AERO @CoryMartin-NOAA
jobs/JGLOBAL_PREP_OCEAN_OBS @guillaumevernieres @AndrewEichmann-NOAA
jobs/JGLOBAL_*SNOW* @jiaruidong2017
jobs/JGLOBAL_STAGE_IC @DavidHuber-NOAA @aerorahul
Expand Down Expand Up @@ -161,6 +160,7 @@ ush/gaussian_sfcanl.sh @BrianCurtis-NOAA
ush/getdump.sh @DavidHuber-NOAA @aerorahul
ush/getges.sh @DavidHuber-NOAA @aerorahul
ush/getgfsnctime @CoryMartin-NOAA
ush/getioda.sh @nicholasesposito @CoryMartin-NOAA @RussTreadon-NOAA
ush/getncdimlen @CoryMartin-NOAA
ush/gfs_bfr2gpk.sh @BoCui-NOAA
ush/gfs_bufr.sh @BoCui-NOAA
Expand Down Expand Up @@ -209,7 +209,6 @@ ush/python/pygfs/task/__init__.py @aerorahul
ush/python/pygfs/task/aero_analysis.py @DavidNew-NOAA @CoryMartin-NOAA
ush/python/pygfs/task/aero_bmatrix.py @DavidNew-NOAA @CoryMartin-NOAA
ush/python/pygfs/task/aero_emissions.py @bbakernoaa
ush/python/pygfs/task/aero_prepobs.py @CoryMartin-NOAA
ush/python/pygfs/task/analysis.py @DavidNew-NOAA @RussTreadon-NOAA
ush/python/pygfs/task/analysis_stats.py @CoryMartin-NOAA @DavidNew-NOAA
ush/python/pygfs/task/archive.py @DavidHuber-NOAA
Expand Down
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: Bug Report
description: Report something that is incorrect or broken
labels: ["triage"]
type: "bug"
projects: ["NOAA-EMC/41"]

Expand Down
1 change: 0 additions & 1 deletion .github/ISSUE_TEMPLATE/new_feature.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
name: New Feature
description: New capability is desired
labels: ["triage"]
type: "feature"
projects: ["NOAA-EMC/41"]

Expand Down
5 changes: 5 additions & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@

# Change characteristics
<!-- Choose YES or NO from each of the following and delete the other -->
- Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? YES/NO (If YES, please indicate to which system(s))
- [ ] GFS
- [ ] GEFS
- [ ] SFS
- [ ] GCAFS
- Is this a breaking change (a change in existing functionality)? YES/NO
- Does this change require a documentation update? YES/NO
- Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
Expand Down
105 changes: 105 additions & 0 deletions .github/workflows/bash_code_analysis.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
name: bash_code_analysis
on:
# push:
# branches:
# - develop
pull_request:

workflow_dispatch:

permissions:
contents: read

jobs:

shfmt:
runs-on: ubuntu-22.04

permissions:
contents: read # for actions/checkout to fetch code
pull-requests: read # to get PR metadata
security-events: write

steps:
- name: Checkout code
uses: actions/checkout@v6
with:
fetch-depth: 0

# Switch to this action once whole repo is shfmt compliant
# - name: shfmt scan
# uses: reviewdog/action-shfmt@v1
# with:
# filter_mode: nofilter
# level: warning
# reporter: github-pr-review

- name: Install shfmt
uses: mfinelli/setup-shfmt@v4
- name: shfmt scan
run: shfmt -d dev/jobs dev/job_cards dev/scripts dev/ush ush

shellcheck:
runs-on: ubuntu-22.04

permissions:
contents: read # for actions/checkout to fetch code
pull-requests: read # to get PR metadata
security-events: write

steps:
- name: Checkout code
uses: actions/checkout@v6
with:
submodules: false

- name: Shellcheck Scan
uses: reviewdog/action-shellcheck@v1
with:
filter_mode: nofilter
level: warning
reporter: github-pr-review
path: |
dev/jobs
dev/job_cards
dev/scripts
dev/ush
ush
pattern: |
config.*
J*
*.env
*.sh
*.bash

differential_shellcheck:
# Run again on just changes until whole repo is compliant
runs-on: ubuntu-22.04

permissions:
contents: read # for actions/checkout to fetch code
pull-requests: read # to get PR metadata
security-events: write

steps:
- name: Checkout code
uses: actions/checkout@v6
with:
submodules: false

- name: Shellcheck Scan
uses: reviewdog/action-shellcheck@v1
with:
filter_mode: added
level: warning
reporter: github-pr-review
check_all_files_with_shebangs: true
pattern: |
config.*
J*
*.env
*.sh
*.bash



64 changes: 0 additions & 64 deletions .github/workflows/linters.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
name: pynorms
on: [push, pull_request]
name: python_code_analysis
on:
push:
branches:
- develop
pull_request:

workflow_dispatch:

jobs:
check_norms:
Expand Down
5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ sorc/ocnicepost.fd
#------------------------------
# jobs symlinks
# scripts symlinks
scripts/exglobal_prep_ocean_obs.py
dev/scripts/exglobal_prep_ocean_obs.py
# ush symlinks
ush/bufr2ioda_insitu_profile_argo.py
ush/bufr2ioda_insitu_profile_bathy.py
Expand All @@ -169,18 +169,19 @@ ush/fv3gfs_make_orog.sh
ush/global_chgres.sh
ush/global_chgres_driver.sh
ush/global_cycle_driver.sh
ush/gsi_satbias2ioda_all.sh
ush/jediinc2fv3.py
ush/imsfv3_scf2ioda.py
ush/bufr_snocvr_snomad.py
ush/atparse.bash
ush/run_bufr2ioda.py
ush/bufr2ioda_insitu*
ush/python/gsincdiag_to_ioda
ush/python/ufsda
ush/python/pyiodaconv
ush/python/soca
ush/python/gen_bufr2ioda_json.py
ush/python/gen_bufr2ioda_yaml.py
ush/python/run_bufr2ioda.py
ush/spoc
# ush log file
ush/fetch-fix-data.log
Expand Down
3 changes: 3 additions & 0 deletions dev/ci/cases/pr/C48_S2SW.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ experiment:
edate: 2021032312
yaml: {{ HOMEgfs }}/dev/ci/cases/yamls/gfs_defaults_ci.yaml

skip_ci_on_hosts:
- wcoss2

workflow:
engine: rocoto
rocoto:
Expand Down
3 changes: 2 additions & 1 deletion dev/ci/cases/pr/C48_S2SWA_gefs_RT.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@ experiment:
nens: 30
interval: 24
start: cold
gefstype: near-real-time
gefstype: gefs-real-time
comroot: {{ 'RUNTESTS' | getenv }}/COMROOT
expdir: {{ 'RUNTESTS' | getenv }}/EXPDIR
idate: 2024112500
edate: 2024112500
yaml: {{ HOMEgfs }}/dev/ci/cases/yamls/gefs_defaults_ci.yaml
icsdir: /lfs/h2/emc/ens/noscrub/eric.sinsky/RETRO_ICS

# TODO run on supported platforms once the gefs forecast and subsequent tasks can succeed with RETRO ICs
# Add this to run the stage ic job 'icsdir: /lfs/h2/emc/ens/noscrub/eric.sinsky/RETRO_ICS'
Expand Down
31 changes: 31 additions & 0 deletions dev/ci/cases/pr/C96C48_ufsgsi_hybatmDA.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
experiment:
net: gfs
mode: cycled
pslot: {{ 'pslot' | getenv }}
app: ATM
resdetatmos: 96
resensatmos: 48
comroot: {{ 'RUNTESTS' | getenv }}/COMROOT
expdir: {{ 'RUNTESTS' | getenv }}/EXPDIR
icsdir: {{ 'ICSDIR_ROOT' | getenv }}/C96C48/20250808
idate: 2024022318
edate: 2024022406
nens: 2
interval: 24
start: warm
yaml: {{ HOMEgfs }}/dev/ci/cases/yamls/ufsgsi_hybatmDA_defaults.ci.yaml

skip_ci_on_hosts:
- gaeac5
- gaeac6
- orion
- hercules
- awsepicglobalworkflow

workflow:
engine: rocoto
rocoto:
maxtries: 2
cyclethrottle: 3
taskthrottle: 25
verbosity: 2
2 changes: 0 additions & 2 deletions dev/ci/cases/pr/C96_gcafs_cycled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ experiment:
yaml: {{ HOMEgfs }}/dev/ci/cases/yamls/gcafs_cycled_defaults_ci.yaml

skip_ci_on_hosts:
- orion
- gaeac5
- hercules
- awsepicglobalworkflow
- ursa

Expand Down
1 change: 1 addition & 0 deletions dev/ci/cases/yamls/gcafs_cycled_defaults_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ defaults:
base:
DO_TEST_MODE: "NO"
AERO_ANL_RUNS: "gcdas"
USE_IODADIR: "YES"
1 change: 1 addition & 0 deletions dev/ci/cases/yamls/gfs_extended_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,4 @@ base:
FHMAX_GFS: 384
FHMAX_HF_GFS: 120
DO_TEST_MODE: "NO"
DO_ARCHCOM: "YES"
4 changes: 4 additions & 0 deletions dev/ci/cases/yamls/ufs_hybatmDA_defaults.ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ base:
DO_JEDIATMVAR: "YES"
DO_JEDIATMENS: "YES"
DO_TEST_MODE: "NO"
CASE_ANL: "C48"
USE_IODADIR: "YES"
atmanl:
LAYOUT_X_ATMANL: 4
LAYOUT_Y_ATMANL: 4
Expand All @@ -23,5 +25,7 @@ esfc:
DONST: "NO"
nsst:
NST_MODEL: "1"
prepatmiodaobs:
DO_CONVERT_IODA: "YES"
sfcanl:
DONST: "NO"
Loading