Skip to content

Update gempak scripts to be complaint with static bash code analysis checkers#4323

Merged
DavidHuber-NOAA merged 7 commits intoNOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/shfmt_gempak
Dec 13, 2025
Merged

Update gempak scripts to be complaint with static bash code analysis checkers#4323
DavidHuber-NOAA merged 7 commits intoNOAA-EMC:developfrom
WalterKolczynski-NOAA:feature/shfmt_gempak

Conversation

@WalterKolczynski-NOAA
Copy link
Contributor

Description

Updates the gempak scripts to be compliant with the static bash code analysis checkers.

Mostly just white-space changes with this one except:

  • Renaming a couple scripts to add .sh extension
  • Replacing arithmetic statements with regular bash tests in if-statements

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Only static tests (no access to WCOSS to test gempak)

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@WalterKolczynski-NOAA WalterKolczynski-NOAA marked this pull request as ready for review December 11, 2025 18:21
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@DavidHuber-NOAA
Copy link
Contributor

Launching CI on WCOSS2.

@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress label Dec 12, 2025
@DavidHuber-NOAA
Copy link
Contributor

All tests passed. Merging.

@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Dec 13, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit be51ea0 into NOAA-EMC:develop Dec 13, 2025
6 checks passed
@WalterKolczynski-NOAA WalterKolczynski-NOAA deleted the feature/shfmt_gempak branch December 18, 2025 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants