Skip to content

Generalize AWS config.resources for compute parition; add mem_node_max#4303

Merged
aerorahul merged 1 commit intoNOAA-EMC:developfrom
TaylorRoper-NOAA:feature/generalize_AWSenv
Dec 8, 2025
Merged

Generalize AWS config.resources for compute parition; add mem_node_max#4303
aerorahul merged 1 commit intoNOAA-EMC:developfrom
TaylorRoper-NOAA:feature/generalize_AWSenv

Conversation

@TaylorRoper-NOAA
Copy link
Contributor

Description

This PR generalizes the AWS GFS config.resources.AWSPW file for the default compute partition and specifies mem_node_max for this partition in the AWS machine block for GFS config.resources.

Resolves #4213

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Create generate experiment on AWS using setup_expt.py
  • Edit max_tasks_per_node and/or mem_node_max in AWS block of `config.resources' in experiment directory to various settings
  • Generate and verify nodes and cores settings for jobs with <partition>compute</partition> in resulting rocoto XML file

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@TaylorRoper-NOAA TaylorRoper-NOAA requested review from DavidHuber-NOAA and aerorahul and removed request for aerorahul December 8, 2025 17:53
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aerorahul aerorahul merged commit 9e1ae04 into NOAA-EMC:develop Dec 8, 2025
6 checks passed
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/global-workflow that referenced this pull request Dec 9, 2025
NOAA-EMC#4303)

# Description

This PR generalizes the AWS GFS `config.resources.AWSPW` file for the
default compute partition and specifies `mem_node_max` for this
partition in the AWS machine block for GFS `config.resources`.

Resolves NOAA-EMC#4213
@TaylorRoper-NOAA TaylorRoper-NOAA deleted the feature/generalize_AWSenv branch December 15, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generalize config.resources.AWSPW tasks_per_node settings for default partition to depend on max_tasks_per_node set in config.resources

2 participants