Refactor Local Archiving: Move YAML Logic to archive_vars.py and Handle Ensemble/Deterministic Archiving#4298
Conversation
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Looks good overall. Definitely like the cleanup happening in the YAMLs. I have just one issue on how templates are being rendered.
Also, I'm wondering if the arcdir templates should be split up by RUN rather than NET to remove the if RUN == ... business. I don't think that needs to be part of this issue, though.
aerorahul
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of additional suggestions.
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
Co-authored-by: Rahul Mahajan <[email protected]>
parm/archive/enkf_arcdir.yaml.j2
Outdated
| - "{{ ARCDIR }}" | ||
|
|
||
| copy_opt: | ||
| # Ensemble analysis statistics - REQUIRED |
There was a problem hiding this comment.
If this is a copy_opt should this comment say this files are optional or is the comment correct that these are required files and should be copy_req?
There was a problem hiding this comment.
Yes. Removed Required.
|
@DavidHuber-NOAA @aerorahul All the tests checked. You can trigger off the CI tests now. |
|
All tests passed on WCOSS2. Merging. |
Description
This PR will handle:
Archiving of ensemble output files
Archiving of deterministic (control) output files
Logic, COM paths, and cycle-dependent variables currently defined in the YAML files (
***_arcdir.yaml.j2) will be moved into archive_vars.py. The YAML files will retain only the file-specific archiving definitions.Resolves: Archive Enhancement — Migrate Template Variables from Jinja to Python #3910
Refs: [Enabler] Review the archiving process and determine best paths forward #3656
Type of change
Change characteristics
How has this been tested?
Checklist