Skip to content

Refactor Local Archiving: Move YAML Logic to archive_vars.py and Handle Ensemble/Deterministic Archiving#4298

Merged
DavidHuber-NOAA merged 36 commits intoNOAA-EMC:developfrom
AntonMFernando-NOAA:enabler/archive
Dec 11, 2025
Merged

Refactor Local Archiving: Move YAML Logic to archive_vars.py and Handle Ensemble/Deterministic Archiving#4298
DavidHuber-NOAA merged 36 commits intoNOAA-EMC:developfrom
AntonMFernando-NOAA:enabler/archive

Conversation

@AntonMFernando-NOAA
Copy link
Contributor

Description

  • The archiving process includes two separate components: local archiving (arch_vrfy) and external tar creation (arch_tar). This issue focuses only on local archiving.

This PR will handle:

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • CI tests on hera

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@AntonMFernando-NOAA AntonMFernando-NOAA self-assigned this Dec 4, 2025
@AntonMFernando-NOAA AntonMFernando-NOAA marked this pull request as draft December 4, 2025 21:08
@AntonMFernando-NOAA AntonMFernando-NOAA changed the title Enabler/archive Refactor Local Archiving: Move YAML Logic to archive_vars.py and Handle Ensemble/Deterministic Archiving Dec 4, 2025
Copy link
Contributor

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Definitely like the cleanup happening in the YAMLs. I have just one issue on how templates are being rendered.

Also, I'm wondering if the arcdir templates should be split up by RUN rather than NET to remove the if RUN == ... business. I don't think that needs to be part of this issue, though.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple of additional suggestions.

- "{{ ARCDIR }}"

copy_opt:
# Ensemble analysis statistics - REQUIRED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is a copy_opt should this comment say this files are optional or is the comment correct that these are required files and should be copy_req?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Removed Required.

@AntonMFernando-NOAA
Copy link
Contributor Author

@DavidHuber-NOAA @aerorahul All the tests checked. You can trigger off the CI tests now.

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emcbot emcbot added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 labels Dec 10, 2025
@DavidHuber-NOAA DavidHuber-NOAA added the CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress label Dec 10, 2025
@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Dec 10, 2025
@emcbot emcbot added CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully and removed CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress labels Dec 10, 2025
@DavidHuber-NOAA
Copy link
Contributor

All tests passed on WCOSS2. Merging.

@DavidHuber-NOAA DavidHuber-NOAA added CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully and removed CI-Wcoss2-Running CI testing on WCOSS for this PR is in-progress labels Dec 11, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit 8414673 into NOAA-EMC:develop Dec 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully CI-Wcoss2-Passed CI testing on WCOSS for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archive Enhancement — Migrate Template Variables from Jinja to Python

6 participants