Update ush scripts to comply with bash static code checkers#4292
Merged
DavidHuber-NOAA merged 24 commits intoNOAA-EMC:developfrom Dec 11, 2025
Merged
Update ush scripts to comply with bash static code checkers#4292DavidHuber-NOAA merged 24 commits intoNOAA-EMC:developfrom
DavidHuber-NOAA merged 24 commits intoNOAA-EMC:developfrom
Conversation
DavidHuber-NOAA
previously approved these changes
Dec 9, 2025
Contributor
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
Approve pending successful CI testing.
Contributor
|
Ursa failed silently due to a GitLab runner issue unrelated to this PR. WCOSS2 never ran due to operator error. It is running now. |
Contributor
|
@WalterKolczynski-NOAA All tests passed on all platforms. Could you just merge in develop and resolve the two conflicts? I will re-review and merge after that. |
DavidHuber-NOAA
approved these changes
Dec 11, 2025
Contributor
|
Everything looks good. Thank you @WalterKolczynski-NOAA! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the ush scripts (including dev/ush) to be compliant with the static bash code analysis checkers.
Also updates the reporter for the GH action so that it should be able to post recommendations on PRs.
Type of change
Change characteristics
How has this been tested?
Checklist