Skip to content

Specify marine yamls for gfs ocean analysis archiving#4286

Merged
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
JohnSteffen-NOAA:feature/gfsoceananal_arch
Dec 5, 2025
Merged

Specify marine yamls for gfs ocean analysis archiving#4286
DavidHuber-NOAA merged 3 commits intoNOAA-EMC:developfrom
JohnSteffen-NOAA:feature/gfsoceananal_arch

Conversation

@JohnSteffen-NOAA
Copy link
Contributor

@JohnSteffen-NOAA JohnSteffen-NOAA commented Dec 1, 2025

Description

If merged, this PR will explicitly list the marine yamls to archive during the gfsocean_analysis archiving task. This replaces the * wildcard which was grabbing all of the available yamls in the conf directory, including yaml files that do not need to be archived.

Resolves #4270

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

This PR has been successfully tested on Ursa for one full cycle.

get  '/scratch4/NCEPDEV/global/John.Steffen/hpss_arch/test_gfsocean_arch/gdasocean_analysis.tar' : '/NCEPDEV/emc-global/1year/John.Steffen/URSA/scratch/test_gfsocean_arch/2021070100/gdasocean_analysis.tar' (2025/11/28 20:17:56 12765024256 bytes, 864008.5 KBS )
get  '/scratch4/NCEPDEV/global/John.Steffen/hpss_arch/test_gfsocean_arch/gdasocean_analysis.tar.idx' : '/NCEPDEV/emc-global/1year/John.Steffen/URSA/scratch/test_gfsocean_arch/2021070100/gdasocean_analysis.tar.idx' (2025/11/28 20:17:56 24352 bytes, 26550.5 KBS )
gdas.20210701/00/analysis/ocean/gdas.t00z.jedi_analysis.a006.nc
gdas.20210701/00/analysis/ocean/gdas.t00z.jedi_increment.i006.nc
gdas.20210701/00/analysis/ocean/gdas.t00z.mom6_increment.i006.nc
gdas.20210701/00/analysis/ice/20210630.210000.analysis.cice_model.res.nc
gdas.20210701/00/analysis/ice/gdas.t00z.jedi_analysis.a006.nc
gdas.20210701/00/analysis/ice/gdas.t00z.jedi_increment.i006.nc
gdas.20210701/00/bmatrix/ocean/gdas.t00z.bkgerr_parametric_stddev.nc
gdas.20210701/00/bmatrix/ice/gdas.t00z.bkgerr_parametric_stddev.nc
gdas.20210701/00/conf/gdas.t00z.soca_setcorscales.yaml
gdas.20210701/00/conf/gdas.t00z.soca_chgres.yaml
gdas.20210701/00/conf/gdas.t00z.soca_diagb.yaml
gdas.20210701/00/conf/gdas.t00z.gridgen.yaml
gdas.20210701/00/conf/gdas.t00z.soca_vtscales.yaml
gdas.20210701/00/conf/gdas.t00z.bmat_fields_metadata.yaml
gdas.20210701/00/conf/var.yaml
gdas.20210701/00/conf/gdas.t00z.soca_parameters_diffusion_hz.yaml
gdas.20210701/00/conf/gdas.t00z.soca_parameters_diffusion_vt.yaml
gdas.20210701/00/conf/soca_incpostproc.yaml

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

…ildcard) in the gfsocean_analysis archiving task. This update mimics the archiving in gdasocean_analysis.
@CatherineThomas-NOAA
Copy link
Contributor

Thanks @JohnSteffen-NOAA!

Comparing the new gfsocean_analysis to the previous gdasocean_analysis yamls, is it intentional to not include the soca_parameters_diffusion and soca_incpostproc files?

# soca_parameters_diffusion_vt, and soca_parameters_diffusion_hz when present
- '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}soca_parameters_diffusion_??.yaml'
- '{{ COMIN_CONF | relpath(ROTDIR) }}/soca_incpostproc.yaml'

aerorahul
aerorahul previously approved these changes Dec 2, 2025
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@JohnSteffen-NOAA
Copy link
Contributor Author

Thanks @JohnSteffen-NOAA!

Comparing the new gfsocean_analysis to the previous gdasocean_analysis yamls, is it intentional to not include the soca_parameters_diffusion and soca_incpostproc files?

# soca_parameters_diffusion_vt, and soca_parameters_diffusion_hz when present
- '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}soca_parameters_diffusion_??.yaml'
- '{{ COMIN_CONF | relpath(ROTDIR) }}/soca_incpostproc.yaml'

Let's wait for @guillaumevernieres to comment.

@AndrewEichmann-NOAA
Copy link
Contributor

Thanks @JohnSteffen-NOAA!

Comparing the new gfsocean_analysis to the previous gdasocean_analysis yamls, is it intentional to not include the soca_parameters_diffusion and soca_incpostproc files?

# soca_parameters_diffusion_vt, and soca_parameters_diffusion_hz when present
- '{{ COMIN_CONF | relpath(ROTDIR) }}/{{ head }}soca_parameters_diffusion_??.yaml'
- '{{ COMIN_CONF | relpath(ROTDIR) }}/soca_incpostproc.yaml'

I don't believe that is intentional. IIRC when I last modified the above, I added those files (or at least the form of that wildcard). But let's hear from @guillaumevernieres

@JohnSteffen-NOAA
Copy link
Contributor Author

@AndrewEichmann-NOAA @CatherineThomas-NOAA Correct, this was not intentional and after talking with Guillaume, we should keep these files. So I will amend the PR to include these now.

…to be included in the archiving of the conf directory
Copy link
Contributor

@CatherineThomas-NOAA CatherineThomas-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @JohnSteffen-NOAA!

@DavidHuber-NOAA
Copy link
Contributor

Launching CI on C6.

@emcbot emcbot added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Gaeac6-Running **Bot use only** CI testing on Gaea C6 for this PR is in-progress labels Dec 4, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit a912381 into NOAA-EMC:develop Dec 5, 2025
6 checks passed
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/global-workflow that referenced this pull request Dec 9, 2025
Explicitly list the marine yamls to archive
during the gfsocean_analysis archiving task. This replaces the *
wildcard which was grabbing all of the available yamls in the conf
directory, including yaml files that do not need to be archived.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Gaeac6-Passed **Bot use only** CI testing on Gaea C6 for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

need to specify yamls to be tarred for gfs ocean analysis

6 participants