Skip to content

Reduction in Ocean and Sea Ice Output#4200

Merged
DavidHuber-NOAA merged 49 commits intoNOAA-EMC:developfrom
NeilBarton-NOAA:ocnice_products
Dec 4, 2025
Merged

Reduction in Ocean and Sea Ice Output#4200
DavidHuber-NOAA merged 49 commits intoNOAA-EMC:developfrom
NeilBarton-NOAA:ocnice_products

Conversation

@NeilBarton-NOAA
Copy link
Contributor

@NeilBarton-NOAA NeilBarton-NOAA commented Oct 30, 2025

Description

Addressing
NOAA-EMC/GFS#37
NOAA-EMC/GFS#36
NOAA-EMC/GFS#4
#4163

Reducing the I/O burden by reducing the number of variables, layers, and adding compression.
Also adds archiving for native subsets

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Tested using C192mx025 SFS forecasts. This will be a draft until GFS testing can be done.

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • [] This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@NeilBarton-NOAA NeilBarton-NOAA marked this pull request as ready for review November 3, 2025 18:43
@NeilBarton-NOAA
Copy link
Contributor Author

GFS forecast tested with archiving changes. New interpolated_zgrid file needed, and is at

gaeac6:/gpfs/f6/sfs-emc/scratch/Neil.Barton/CODE/gw_ocnice_products_NeilBarton-NOAA/fix/interpolate_zgrid_30L.nc

NeilBarton-NOAA and others added 2 commits November 3, 2025 16:34
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
Co-authored-by: Rahul Mahajan <aerorahul@users.noreply.github.com>
@NeilBarton-NOAA NeilBarton-NOAA changed the title Reduction on Ocean and Sea Ice Output Reduction in Ocean and Sea Ice Output Nov 5, 2025
@DavidHuber-NOAA DavidHuber-NOAA added CI-Ursa-Running (CM) CI testing is being run locally on Ursa. and removed CI-Ursa-Failed **Bot use only** CI testing on Ursa for this PR has failed labels Dec 3, 2025
@jiandewang
Copy link
Contributor

by checking 11L native ocean file I found only ssh, mld_003 and layered TSUV are being saved. We need to have SST/SSS as they are the key information users need. Note top layer of temp will not be identical to SST though they will be very close (depends on the vertical remap depth settings)

@DavidHuber-NOAA
Copy link
Contributor

All tests passed on Ursa.

@DavidHuber-NOAA DavidHuber-NOAA removed the CI-Ursa-Running (CM) CI testing is being run locally on Ursa. label Dec 3, 2025
@DavidHuber-NOAA
Copy link
Contributor

@jiandewang I will wait for approval from you before relaunching tests.

@jiandewang
Copy link
Contributor

I checked ocean output, they are fine as expected.

jiandewang
jiandewang previously approved these changes Dec 3, 2025
@emcbot emcbot added CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress and removed CI-Ursa-Ready **CM use only** PR is ready for CI testing on Ursa CI-Ursa-Building **Bot use only** CI testing is cloning/building on Ursa labels Dec 3, 2025
@emcbot
Copy link

emcbot commented Dec 3, 2025

C96mx100_S2S FAILED on Ursa (pipeline ID: 6067)

In directory: /scratch3/NCEPDEV/global/role.glopara/GFS_CI_CD/URSA/BUILDS/GITLAB/pr_cases_4200_da19eb69_6067/RUNTESTS/EXPDIR/C96mx100_S2S_da19eb69-6067

This failure was detected automatically by global-workflow's CI/CD Pipeline

@emcbot emcbot added CI-Ursa-Failed **Bot use only** CI testing on Ursa for this PR has failed and removed CI-Ursa-Running **Bot use only** CI testing on Ursa for this PR is in-progress labels Dec 3, 2025
Comment on lines 321 to 322
export DO_ARCHCOM="{{ DO_ARCHCOM }}" # Tar and archive the COM directories
export ARCHCOM_TO="{{ ARCHCOM_TO }}" # Valid options are hpss, globus_hpss, and local
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeilBarton-NOAA These lines are triggering the arch_tars dependency on the sfs_cleanup task. Since sfs_arch_tars does not exist, this is causing a stall. Can you please set DO_ARCHCOM to NO for now and reinstate these lines on the next PR that enables archiving?

@DavidHuber-NOAA DavidHuber-NOAA added CI-Ursa-Passed (cm) Manual CI passed on Ursa and removed CI-Ursa-Failed **Bot use only** CI testing on Ursa for this PR has failed labels Dec 4, 2025
@DavidHuber-NOAA
Copy link
Contributor

@NeilBarton-NOAA Thanks! The SFS cleanup task now runs without issue. Merging.

@DavidHuber-NOAA DavidHuber-NOAA merged commit 4ff8e19 into NOAA-EMC:develop Dec 4, 2025
6 checks passed
@NeilBarton-NOAA NeilBarton-NOAA deleted the ocnice_products branch December 8, 2025 21:28
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/global-workflow that referenced this pull request Dec 9, 2025
Reducing the I/O burden by reducing the number of variables, layers, and
adding compression.
Also adds archiving for native subsets
DingLiuNOAA added a commit to NOAA-PSL/global-workflow that referenced this pull request Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Ursa-Passed (cm) Manual CI passed on Ursa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants