Skip to content

GCAFS prep emissions update - fire emissions #3713

Merged
DavidHuber-NOAA merged 217 commits intoNOAA-EMC:developfrom
bbakernoaa:feature/prep_emis_rework
Dec 16, 2025
Merged

GCAFS prep emissions update - fire emissions #3713
DavidHuber-NOAA merged 217 commits intoNOAA-EMC:developfrom
bbakernoaa:feature/prep_emis_rework

Conversation

@bbakernoaa
Copy link
Contributor

@bbakernoaa bbakernoaa commented May 20, 2025

Description

Resolves #3712
Resolves #3827
Resolves #4248

This pull request introduces significant updates to the aerosol configuration and emission handling in the UFS-Aerosols system, streamlining file management, improving modularity, and consolidating configuration files. Key changes include restructuring aerosol configuration files, enhancing biomass burning emissions handling, and updating the chemical input file linking process.

Aerosol Configuration Updates:

  • Refactored config.aero.j2 to organize settings into distinct sections for aerosol and emission configurations, including the addition of new variables like AERO_EMIS_FIRE_VERSION and AERO_EMIS_FIRE_HIST. [1] [2]

Emission Data Management:

  • Consolidated multiple emission configuration files (ExtData.gbbepx, ExtData.qfed, and ExtData.none) into a single file, AERO_ExtData.rc, for better modularity and maintainability. Removed redundant and unused emission entries. [1] [2] [3] [4]

Chemical Input File Handling:

  • Added linking of chemical input files (CHEM_INPUT) in forecast_predet.sh to ensure proper file availability during runtime.

Removal of Legacy Code:

  • Removed the automated generation of AERO_ExtData.rc in parsing_namelists_GOCART.sh, as the new consolidated configuration file eliminates the need for dynamic generation.

Additional Updates:

  • Updated config.com to include new template paths for chemical restart and input files, improving file organization.

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • GCAFS noDA cycled on URSA

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@CoryMartin-NOAA CoryMartin-NOAA requested a review from Copilot May 20, 2025 20:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates aerosol configuration and emissions handling for the UFS-Aerosols system by consolidating file management and enhancing modularity. Key changes include:

  • Removing legacy logic for generating the AERO_ExtData.rc file and consolidating emission configuration files.
  • Adding a link to chemical input files in forecast_predet.sh and updating configuration templates in both aerosol and chemical configuration files.
  • Refactoring configuration files to improve clarity and maintainability.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ush/parsing_namelists_GOCART.sh Removed legacy dynamic generation of AERO_ExtData.rc.
ush/forecast_predet.sh Added linking for CHEM_INPUT to ensure chemical input file availability.
parm/ufs/gocart/ExtData.* Removed obsolete emission configuration files, consolidating them into AERO_ExtData.rc.
parm/ufs/gocart/AERO_ExtData.rc Updated emission entries to use chemical input paths and adjusted emission factors.
parm/chem/chem_emission.yaml.j2 Updated templating loops for QFED variables and file copying operations.
dev/parm/config/gfs/config.com Added new chemical template paths.
dev/parm/config/gcafs/config.aero.j2 Reorganized aerosol sections and introduced new aerosol emission settings.

@bbakernoaa bbakernoaa force-pushed the feature/prep_emis_rework branch from 2e06fb3 to b534a8b Compare July 31, 2025 19:47
@bbakernoaa bbakernoaa marked this pull request as ready for review August 7, 2025 15:21
@bbakernoaa bbakernoaa requested a review from aerorahul as a code owner August 7, 2025 15:21
@emcbot emcbot added CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Gaeac6-Ready **CM use only** PR is ready for CI testing on Gaea C6 CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Dec 12, 2025
@emcbot
Copy link

emcbot commented Dec 13, 2025

C96_gcafs_cycled_noDA FAILED on Hera (pipeline ID: 6335)

In directory: /scratch3/NCEPDEV/global/role.glopara/GFS_CI_CD/HERA/BUILDS/GITLAB/pr_cases_3713_d3952e99_6335/RUNTESTS/EXPDIR/C96_gcafs_cycled_noDA_d3952e99-6335

Error Log Files:


/scratch3/NCEPDEV/global/role.glopara/GFS_CI_CD/HERA/BUILDS/GITLAB/pr_cases_3713_d3952e99_6335/RUNTESTS/COMROOT/C96_gcafs_cycled_noDA_d3952e99-6335/logs/2021122018/gcafs_arch_tars.log

View Error Logs: (gcafs_arch_tars.log)

This failure was detected automatically by global-workflow's CI/CD Pipeline

@emcbot emcbot removed the CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress label Dec 13, 2025
@emcbot
Copy link

emcbot commented Dec 13, 2025

C96_gcafs_cycled FAILED on Hera (pipeline ID: 6335)

In directory: /scratch3/NCEPDEV/global/role.glopara/GFS_CI_CD/HERA/BUILDS/GITLAB/pr_cases_3713_d3952e99_6335/RUNTESTS/EXPDIR/C96_gcafs_cycled_d3952e99-6335

Error Log Files:


/scratch3/NCEPDEV/global/role.glopara/GFS_CI_CD/HERA/BUILDS/GITLAB/pr_cases_3713_d3952e99_6335/RUNTESTS/COMROOT/C96_gcafs_cycled_d3952e99-6335/logs/2021122018/gcafs_arch_tars.log

View Error Logs: (gcafs_arch_tars.log)

This failure was detected automatically by global-workflow's CI/CD Pipeline

@TerrenceMcGuinness-NOAA TerrenceMcGuinness-NOAA removed the CI-Gaeac6-Building **Bot use only** CI testing is cloning/building on Gaea C6 label Dec 16, 2025
@DavidHuber-NOAA
Copy link
Contributor

The GCAFS failures here are only due to archiving and are known. Merging.

@CoryMartin-NOAA
Copy link
Contributor

Thank you @DavidHuber-NOAA !!

@DavidHuber-NOAA DavidHuber-NOAA added CI-Hera-Passed (cm) Manual CI passed on Hera and removed CI-Hera-Failed **Bot use only** CI testing on Hera for this PR has failed CI-Gaeac6-Failed **Bot use only** CI testing on Gaea C6 for this PR has failed labels Dec 16, 2025
@DavidHuber-NOAA DavidHuber-NOAA merged commit a05fd27 into NOAA-EMC:develop Dec 16, 2025
7 checks passed
@bbakernoaa
Copy link
Contributor Author

Thank you @DavidHuber-NOAA and @aerorahul for all your help and suggestions. Very happy the GitHub gods finally found a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-Hera-Passed (cm) Manual CI passed on Hera CI-Ursa-Passed **Bot use only** CI testing on Ursa for this PR has completed successfully

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GCAFSv1 Input data Add NEXUS as a submodule to the global-workflow GCAFS Prep emissions - fire update

10 participants