Remove compiler remarks in debug build

[mingchen-NOAA]

Pull Request Summary

This PR silences 1460 compiler remarks resulting in cleaner WW3/GFS debug builds.

Description

The PR resolves compiler remarks in WW3 during debug build by addressing remark #7712 (“variable has not been used”): unused variables were removed.

Merged commits/PRs list:
#1542: Initiatlise XFT variable outside of ST2 switch
#1546: Fix non-B4B issue in ww3_tp2.1 by using separate output filenames for dual postprocessing steps
#1548: Partial fix WW3 and operational workflows compiler remarks in debug build
#1551: Remove goto statements in wav_shel_in.F90
#1556: Partially address compiler remarks in WW3 and operational workflow when using debug build
#1557: Partially remove compiler remarks in WW3 and operational workflow when using debug build
#1558: Remove compiler remarks in modules w3tidemd, w3updtmd, w3wavemd, and w3srcemd
#1561: Silence compiler remarks in modules and programs w3wdasmd ww3_outf ww3_outp ww3_grib ww3_gint
#1562: Fix compiler remarks in modules w3arrymd, w3fldsmd, w3gdatmd, w3idatmd, w3odatmd, w3parall, and w3timemd
#1563: Remove compiler remarks for operational workflow
#1564: Address compiler remarks in modules w3iogomd, w3iogrmd, w3iorsmd
#1565: Remove compiler remarks in PDLIB functions
#1566: Remove remaining compiler remarks in w3initmd, w3iobcmd, w3parall,
#1567: Fix remaining compiler remarks in w3profsmd_pdlib.F90 and pdlib_field_vec.F90

Possible result changes in ww3_tp2.1 from #1546 compared to dev/ufs-weather-model

ww3_tp2.1/./work_PR2_UNO 
ww3_tp2.1/./work_PR1_MPI 
ww3_tp2.1/./work_PR3_UNO_MPI  
ww3_tp2.1/./work_PR2_UQ 
ww3_tp2.1/./work_PR2_UNO_MPI 
ww3_tp2.1/./work_PR3_UNO  
ww3_tp2.1/./work_PR3_UQ_MPI 
ww3_tp2.1/./work_PR1 
ww3_tp2.1/./work_PR3_UQ 
ww3_tp2.1/./work_PR2_UQ_MPI

No result changes were expected from UFSWM RT suites.

Issue(s) addressed

Addressing issue #1501

Commit Message

Fix compiler remarks during debug build

Check list

• Branch is up to date with the authoritative repository (NOAA-EMC) develop branch.
• Checked the checklist for a developer submitting to develop.
• If a version number update is required, checked the updating version number checklist.
• If a new feature was added, a regression test for testing the new feature is added.

Testing

• How were these changes tested? Matrix compared to dev/ufs-weather-model
• Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Yes
• Have the matrix regression tests been run (if yes, please note HPC and compiler)? Ursa Intel
• Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
• Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

Known non-identical cases:

**********************************************************************
********************* non-identical cases ****************************
**********************************************************************
mww3_test_03/./work_PR3_UNO_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR1_MPI_d2                     (14 files differ)
mww3_test_03/./work_PR2_UQ_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_e_c                     (1 files differ)
mww3_test_03/./work_PR2_UNO_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR2_UQ_MPI_d2                     (15 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2_c                     (15 files differ)
mww3_test_03/./work_PR2_UNO_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UQ_MPI_d2                     (16 files differ)
mww3_test_03/./work_PR1_MPI_e                     (1 files differ)
mww3_test_03/./work_PR3_UNO_MPI_d2_c                     (19 files differ)
mww3_test_03/./work_PR3_UNO_MPI_e_c                     (1 files differ)
mww3_test_09/./work_MPI_ASCII                     (0 files differ)
ww3_tp2.10/./work_MPI_OMPH                     (7 files differ)
ww3_tp2.6/./work_ST4_ASCII                     (0 files differ)
ww3_ufs1.3/./work_a                     (3 files differ)

Non-identical from #1546

ww3_tp2.1/./work_PR2_UNO                     (2 files differ)
ww3_tp2.1/./work_PR1_MPI                     (2 files differ)
ww3_tp2.1/./work_PR3_UNO_MPI                     (2 files differ)
ww3_tp2.1/./work_PR2_UQ                     (2 files differ)
ww3_tp2.1/./work_PR2_UNO_MPI                     (2 files differ)
ww3_tp2.1/./work_PR3_UNO                     (2 files differ)
ww3_tp2.1/./work_PR3_UQ_MPI                     (2 files differ)
ww3_tp2.1/./work_PR1                     (2 files differ)
ww3_tp2.1/./work_PR3_UQ                     (2 files differ)
ww3_tp2.1/./work_PR2_UQ_MPI                     (2 files differ)

matrixCompFull.txt
matrixCompSummary.txt
matrixDiff.txt

[mingchen-NOAA]

UFSWM RT Tests on WCOSS2 for GFS:

PASS -- COMPILE 's2swa_32bit_pdlib_intel' [18:36, 16:45] ( 1 warnings 1 remarks )
PASS -- TEST 'cpld_control_gfsv17_intel' [18:14, 13:46](1897 MB)
PASS -- TEST 'cpld_control_gfsv17_iau_intel' [19:22, 14:30](1940 MB)
PASS -- TEST 'cpld_restart_gfsv17_intel' [11:13, 06:38](1068 MB)
PASS -- TEST 'cpld_restart_gfsv17_iau_intel' [11:25, 06:44](1934 MB)
PASS -- TEST 'cpld_mpi_gfsv17_intel' [19:40, 15:35](1877 MB)

/lfs/h2/emc/couple/noscrub/ming.chen/ufswm/prod4gfsv17/UFSATM/ccpp/physics/physics/Radiation/RRTMGP/rte-rrtmgp/rte-frontend/mo_rte_lw.F90(137): warning #7922: The value was too small when converting to REAL(KIND=8); the result is in the denormalized range.
        gauss_Ds  = 1._wp / &
--------------------^

/lfs/h2/emc/couple/noscrub/ming.chen/ufswm/prod4gfsv17/UFSATM/ccpp/physics/physics/SFC_Models/Land/Noahmp/module_sf_noahmplsm.F90(9999): remark #7713: This statement function has not been used.   [R]
   real (kind=kind_phys) :: r,x
 ---------------------------^

/lfs/h2/emc/couple/noscrub/ming.chen/ufswm/prod4gfsv17/tests/

[mingchen-NOAA]

Baseline:
PASS -- COMPILE 's2swa_32bit_pdlib_debug_intel' [06:21, 04:51] ( 334 warnings 1784 remarks )

This PR:
PASS -- COMPILE 's2swa_32bit_pdlib_debug_intel' [07:22, 05:11] ( 334 warnings 324 remarks )
PASS -- TEST 'cpld_debug_gfsv17_intel' [25:13, 20:23](1939 MB)

/lfs/h2/emc/couple/noscrub/ming.chen/ufswm/prod4gfsv17/tests/

[JessicaMeixner-NOAA]

@mingchen-NOAA thank you so much for creating this PR. What a HUGE improvement on the remarks!!!

@dpsarmie is going to run this with some other updates he has planned to test as the independent tester for this since I'll be on leave tomorrow. I have however reviewed the code, so once we get the okay from Dan we can merge.

[dpsarmie]

@mingchen-NOAA Ursa is being incredibly slow today, but from the tests so far this should be good to go. Were these pushed to develop via ufs-community/ufs-weather-model#3091 or other PRs?

[mingchen-NOAA]

@mingchen-NOAA Ursa is being incredibly slow today, but from the tests so far this should be good to go. Were these pushed to develop via ufs-community/ufs-weather-model#3091 or other PRs?

@dpsarmie ufs-community/ufs-weather-model#3091 contains two additional commits that are not intended to be included in production. I reverted those two in this PR.

[dpsarmie]

Ok, feel free to merge this into the production branch