Skip to content

Buoy updates #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ghazal-Mohammadpour wants to merge 29 commits into
base: develop
Choose a base branch
from
Open

Buoy updates #68

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
2e1cbe9
Now can read different model names
Mar 6, 2024
1dcfcb1
wind value added to the NDBC and the Copernp removed until the reliab…
Mar 6, 2024
0085a91
added .spec reader to the buoy valodation code
Mar 21, 2024
5c304ea
added .spec and also is able to to the hs calculations in the code
Mar 25, 2024
12a8a9d
wind variable added to the .spec in a list of buoy nams and boy IDs
Apr 8, 2024
4c29c4c
hs and tp added to the .spec file format
Apr 11, 2024
9c09915
removed
Apr 11, 2024
c22d3c5
removed an extra discription
Apr 18, 2024
afbc2af
update the branch
Apr 22, 2024
e1f3616
added .spec and also is able to to the hs calculations in the code
Mar 25, 2024
6592b96
modified
Apr 22, 2024
8a06fb1
Description added to the modelBuoy_collocation.py
Apr 22, 2024
11b026d
removed extra comments
Apr 22, 2024
99e2ed1
updated instruction on how to use the .spec (gz)
Apr 22, 2024
c0aa513
description updated
Apr 22, 2024
a1e3ed5
Fixed the parameter in the unzip_and_untar function to use extracted_…
May 5, 2024
cc6b14a
Merge remote-tracking branch 'origin/develop' into buoy_updates
May 25, 2024
0adf9f5
The code is updated to be able to process the spec.gz buoy file formats
May 25, 2024
a2d5b33
hs and tp added to the .spec file format
May 25, 2024
9ff9e0e
The code is updated to be able to process the spec.gz buoy file formats
May 25, 2024
e00676e
updated the script with the proper description and the parsing issue …
May 28, 2024
e0cb3e7
This commit updates the calculation of total observations in the ncfi…
May 30, 2024
e7ba943
Improve dfreq calculation to reflect logarithmic frequency spacing.
May 30, 2024
26dc812
commented out the mtime
May 31, 2024
1c50b8f
removed the checking comments
May 31, 2024
2ea55cb
added the initial_condition as a global value and also added the fcst…
Jun 10, 2024
6a60e5e
added the ability to read another spec file variable format
Jun 10, 2024
da9cbe2
Updated instruction on how to use format other than spec.gz
Jun 24, 2024
0336405
added Cyclonemap and gridinfo to this version
Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ww3tools/modelBuoy_collocation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,10 @@ def unzip_and_untar(gz_file, output_dir):

ncfile = nc.Dataset(f'WW3.{model_name}Buoy{ftag}_{initime}to{fintime}.nc', "w", format=fnetcdf)
print(f"Model Name: {model_name}, Tag: {ftag}, Start Time: {initime}, End Time: {fintime}")
ncfile.history = "Matchups of WAVEWATCHIII point output (table) and NDBC and Copernicus Buoys. Total of " + repr(bhs[bhs > 0.].shape[0]) + " observations or pairs model/observation."
num_time_points = nmhs.shape[2] # Total number of time points
num_buoy_points = bhs.shape[0] # Total number of buoy points
total_observations = num_time_points * num_buoy_points
ncfile.history = "Matchups of WAVEWATCHIII point output (table) and NDBC and Copernicus Buoys. Total of " + str(total_observations) + " observations or pairs model/observation."
Copy link
Collaborator

@sbanihash sbanihash May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ghazal-Mohammadpour I am not sure about this change. We have to actually calculate the matchups. similar to what was in the code before. What you have added here assumes that for each station and model time step we have buoy data which is not always correct, that is the maximum matchups we could get. The output you had shared had "Total of 4417048 observations or pairs model/observation." which was way beyond the number I was expecting for 166 buoys and 57 timesteps. Please take a closer look and check this.


# create dimensions
ncfile.createDimension('buoypoints', bhs.shape[0])
Expand Down