Skip to content

Changes to the ADPUPA wind obs space ObsErrorFactorConventional filter#539

Merged
ShunLiu-NOAA merged 2 commits intoNOAA-EMC:developfrom
delippi:feature/adpupa_wind_oefc_fix
Feb 25, 2026
Merged

Changes to the ADPUPA wind obs space ObsErrorFactorConventional filter#539
ShunLiu-NOAA merged 2 commits intoNOAA-EMC:developfrom
delippi:feature/adpupa_wind_oefc_fix

Conversation

@delippi
Copy link
Collaborator

@delippi delippi commented Feb 24, 2026

Description

This PR removes a few lines from the ObsErrorFactorConventional filter in the ADPUPA 220/232 observation yamls for better agreement with GSI observation errors through in-workflow testing. As expected, this changes the ctest results for the upper air ctest and the reference was updated accordingly.

Checklist

  • I have performed a self-review of my own code.
  • I have run rrfs tests before creating the PR (if applicable).

@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 24, 2026

PASSED on hera

started build_and_test on hera at UTC time: Tue Feb 24 18:51:18 UTC 2026
finished at UTC time: Tue Feb 24 19:23:53 UTC 2026

Test project /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/539/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
 1/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   36.16 sec
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
 2/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed   52.15 sec
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 3/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed   59.86 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 4/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   17.09 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 5/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed   45.05 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 6/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed   58.89 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 7/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed   60.22 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 8/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  130.39 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 9/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  171.50 sec
      Start 18: rrfs_bufr2ioda_msonet
10/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  174.07 sec
11/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  175.49 sec
12/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed   49.01 sec
13/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   23.93 sec
14/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  266.96 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
15/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  258.09 sec
16/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  333.22 sec
17/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  313.08 sec
18/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  195.79 sec

100% tests passed, 0 tests failed out of 18

Label Time Summary:
mpi            = 2420.95 sec*proc (18 tests)
rdas-bundle    = 2420.95 sec*proc (18 tests)
script         = 2420.95 sec*proc (18 tests)

Total Test time (real) = 462.80 sec

workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/539

@SamuelDegelia-NOAA
Copy link
Contributor

PASSED on wcoss2

started build_and_test on wcoss2 at UTC time: Tue Feb 24 18:52:39 UTC 2026
finished at UTC time: Tue Feb 24 19:49:51 UTC 2026

Test project /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/539/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 1/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   78.76 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 2/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   88.69 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 3/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed  101.64 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 4/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed  109.67 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 5/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed  146.67 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 6/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed  139.07 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 7/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  252.65 sec
      Start 18: rrfs_bufr2ioda_msonet
 8/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  257.80 sec
 9/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   32.33 sec
10/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  297.68 sec
11/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed  155.98 sec
12/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  309.67 sec
13/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed  102.77 sec
14/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  373.11 sec
15/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  522.88 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
16/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  477.96 sec
17/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  690.97 sec
18/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  310.78 sec

100% tests passed, 0 tests failed out of 18

Label Time Summary:
rdas-bundle    = 4449.08 sec*proc (18 tests)
script         = 4449.08 sec*proc (18 tests)

Total Test time (real) = 833.68 sec

workdir: /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/539

@ShunLiu-NOAA ShunLiu-NOAA merged commit 464182e into NOAA-EMC:develop Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants