Skip to content

Add option to turn on per outerloop increments#537

Merged
ShunLiu-NOAA merged 1 commit intoNOAA-EMC:developfrom
delippi:feature/per_outer_loop_inc
Feb 13, 2026
Merged

Add option to turn on per outerloop increments#537
ShunLiu-NOAA merged 1 commit intoNOAA-EMC:developfrom
delippi:feature/per_outer_loop_inc

Conversation

@delippi
Copy link
Collaborator

@delippi delippi commented Feb 13, 2026

Description

This PR adds the option to turn on writing out per outer loop analysis increment fields if the following is used. The option is off by default.

write_increment_outer_loop_1: true
write_increment_outer_loop_2: true

Issue(s) addressed

In part #518. Turning this on allows us to confirm that delp is updated between outerloops when used as analysis variable and not control variable.

Checklist

  • I have performed a self-review of my own code.
  • I have run rrfs tests before creating the PR (if applicable).
  • Unit tests added/updated (if applicable).

@ShunLiu-NOAA ShunLiu-NOAA merged commit 6e3dbe8 into NOAA-EMC:develop Feb 13, 2026
1 check passed
@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 13, 2026

PASSED on hera

started build_and_test on hera at UTC time: Fri Feb 13 18:45:01 UTC 2026
finished at UTC time: Fri Feb 13 19:12:42 UTC 2026

Test project /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/537/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
 1/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   38.87 sec
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
 2/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed   56.22 sec
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 3/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed   58.85 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 4/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   24.43 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 5/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed   47.02 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 6/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed   63.50 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 7/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  135.34 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 8/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed   63.13 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 9/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  171.55 sec
      Start 18: rrfs_bufr2ioda_msonet
10/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  181.27 sec
11/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  181.54 sec
12/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed   50.30 sec
13/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   23.71 sec
14/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  218.15 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
15/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  257.55 sec
16/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  176.54 sec
17/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  331.62 sec
18/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  303.02 sec

100% tests passed, 0 tests failed out of 18

Label Time Summary:
mpi            = 2382.61 sec*proc (18 tests)
rdas-bundle    = 2382.61 sec*proc (18 tests)
script         = 2382.61 sec*proc (18 tests)

Total Test time (real) = 425.40 sec

workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/537

@SamuelDegelia-NOAA
Copy link
Contributor

PASSED on wcoss2

started build_and_test on wcoss2 at UTC time: Fri Feb 13 18:20:01 UTC 2026
finished at UTC time: Fri Feb 13 19:14:48 UTC 2026

Test project /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/537/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 1/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   85.98 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 2/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   85.97 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 3/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed   98.96 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 4/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed  103.97 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 5/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed  147.26 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 6/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed  131.99 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 7/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  249.97 sec
      Start 18: rrfs_bufr2ioda_msonet
 8/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  251.97 sec
 9/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   34.38 sec
10/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  293.97 sec
11/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  306.97 sec
12/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed  163.72 sec
13/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed  118.00 sec
14/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  349.99 sec
15/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  478.00 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
16/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  495.99 sec
17/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  675.03 sec
18/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  313.99 sec

100% tests passed, 0 tests failed out of 18

Label Time Summary:
rdas-bundle    = 4386.09 sec*proc (18 tests)
script         = 4386.09 sec*proc (18 tests)

Total Test time (real) = 792.01 sec

workdir: /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants