Skip to content

Add JCB variables for horizontal localization radius and halo size used in GETKF#535

Merged
ShunLiu-NOAA merged 1 commit intoNOAA-EMC:developfrom
SamuelDegelia-NOAA:feature/hloc_halo_jcbvar
Feb 10, 2026
Merged

Add JCB variables for horizontal localization radius and halo size used in GETKF#535
ShunLiu-NOAA merged 1 commit intoNOAA-EMC:developfrom
SamuelDegelia-NOAA:feature/hloc_halo_jcbvar

Conversation

@SamuelDegelia-NOAA
Copy link
Contributor

Description

When setting up the JEDI-based EnKF retros in rrfs-workflow, it was found that the horizontal localization settings in our JEDI YAMLs did not match those used in GSI-based RRFSv1. To address this, this small PR adds JCB variables that allow the horizontal localization radius and halo size to be configured explicitly. Separate variables are defined for conventional and dbz observations to be consistent with the existing RRFSv1 configuration.

The default values in the YAMLs are unchanged so that the current ctest results remain identical. At this stage, the updated localization values will be applied only through the JCB configuration files used by in rrfs-workflow.

For reference, the following GSI values are currently used and will be adopted for the upcoming retros:

CORRLENGTH = 300
CORRLENGTH_radardbz = 18
LNSIGCUTOFF = 0.5
LNSIGCUTOFF_radardbz = 0.5

Note that the vertical localization lengthscale is already configurable as a JCB variable and matches what is used in GSI.

Issue(s) addressed

None

Dependencies (if applicable)

None

Checklist

  • I have performed a self-review of my own code.
  • I have run rrfs tests before creating the PR (if applicable).
  • Unit tests added/updated (if applicable).

@SamuelDegelia-NOAA
Copy link
Contributor Author

PASSED on wcoss2

started build_and_test on wcoss2 at UTC time: Mon Feb 9 19:23:01 UTC 2026
finished at UTC time: Mon Feb 9 20:18:08 UTC 2026

Test project /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/535/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 1/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   74.27 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 2/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   93.73 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 3/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed   99.71 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 4/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed   99.71 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 5/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed  139.73 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 6/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed  133.39 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 7/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  244.73 sec
      Start 18: rrfs_bufr2ioda_msonet
 8/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  249.82 sec
 9/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   36.74 sec
10/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  290.71 sec
11/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  301.70 sec
12/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed  170.95 sec
13/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed  111.88 sec
14/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  341.02 sec
15/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  480.84 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
16/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  492.07 sec
17/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  683.04 sec
18/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  351.90 sec

100% tests passed, 0 tests failed out of 18

Label Time Summary:
rdas-bundle    = 4395.95 sec*proc (18 tests)
script         = 4395.95 sec*proc (18 tests)

Total Test time (real) = 832.83 sec

workdir: /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/535

Copy link
Collaborator

@delippi delippi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@SamuelDegelia-NOAA SamuelDegelia-NOAA marked this pull request as ready for review February 9, 2026 21:34
@SamuelDegelia-NOAA
Copy link
Contributor Author

Not sure why the Hera CI tests were not posted. Here are the results:

[Samuel.Degelia@hfe01 535]$ cd /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/535
[Samuel.Degelia@hfe01 535]$ cat comments.txt
Test project /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/535/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
 1/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   30.86 sec
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
 2/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed   50.07 sec
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 3/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed   56.24 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 4/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   16.63 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 5/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed   44.13 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 6/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........***Failed    2.97 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 7/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed   56.82 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 8/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  120.38 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 9/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed   72.49 sec
      Start 18: rrfs_bufr2ioda_msonet
10/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  157.83 sec
11/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  161.98 sec
12/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  163.40 sec
13/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   36.30 sec
14/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed   55.36 sec
15/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  209.41 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
16/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  260.31 sec
17/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  306.56 sec
18/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  176.61 sec

94% tests passed, 1 tests failed out of 18

Label Time Summary:
mpi            = 1978.35 sec*proc (18 tests)
rdas-bundle    = 1978.35 sec*proc (18 tests)
script         = 1978.35 sec*proc (18 tests)

Total Test time (real) = 386.06 sec

The following tests FAILED:
         12 - rrfs_fv3jedi_2024052700_3denvar_refl (Failed)
Errors while running CTest
Output from these tests are in: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/535/build/rrfs-test/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/535

The error for rrfs_fv3jedi_2024052700_3denvar_refl seems to be due to instability on Hera:

srun: job 21776016 queued and waiting for resources
srun: job 21776016 has been allocated resources
srun: error: h4c08: tasks 49-55: Bus error
srun: Terminating StepId=21776016.0
[2026-02-09T19:43:52.605] error: *** STEP 21776016.0 ON h4c01 CANCELLED AT 2026-02-09T19:43:52 DUE TO TASK FAILURE ***

I think this PR is okay to move ahead since the failure is not related to this PR.

@ShunLiu-NOAA ShunLiu-NOAA merged commit c362127 into NOAA-EMC:develop Feb 10, 2026
1 check passed
@SamuelDegelia-NOAA SamuelDegelia-NOAA deleted the feature/hloc_halo_jcbvar branch February 10, 2026 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants