Skip to content

Minor updates to JCB files to prepare for JEDI-based EnKF in rrfs-workflow#532

Merged
ShunLiu-NOAA merged 7 commits intoNOAA-EMC:developfrom
SamuelDegelia-NOAA:feature/udpate_jcb_for_enkf_wflow
Feb 6, 2026
Merged

Minor updates to JCB files to prepare for JEDI-based EnKF in rrfs-workflow#532
ShunLiu-NOAA merged 7 commits intoNOAA-EMC:developfrom
SamuelDegelia-NOAA:feature/udpate_jcb_for_enkf_wflow

Conversation

@SamuelDegelia-NOAA
Copy link
Contributor

@SamuelDegelia-NOAA SamuelDegelia-NOAA commented Feb 4, 2026

Description

This is a minor PR to clean up the JCB templates and configuration files in preparation for adding the JEDI-based EnKF functionality to rrfs-workflow. The changes are:

  1. Remove hard-coded filenames and variables from atmosphere_background_ensemble.yaml.j2 so that this template can instead be filled by info passed in through the JCB config file
  2. Set the state variables for the GETKF ctests to what was originally intended but was overwritten due to the hard-coding in (1). This also requires an update to the test references but note that the analysis results do not change
  3. Add a new template for atmosphere_output_ensemble_increments.yaml.j2 that allows us to write out ensemble increments instead of only outputting the ensemble mean background and analysis

Issue(s) addressed

None

Dependencies (if applicable)

None

Checklist

  • I have performed a self-review of my own code.
  • I have run rrfs tests before creating the PR (if applicable).
  • Unit tests added/updated (if applicable).

@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 4, 2026

FAILED on hera

started build_and_test on hera at UTC time: Wed Feb 4 21:21:29 UTC 2026
finished at UTC time: Wed Feb 4 21:41:50 UTC 2026

Test project /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
 1/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....***Failed    0.07 sec
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
 2/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........***Failed    0.10 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 3/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......***Failed    0.09 sec
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 4/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................***Failed    0.09 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 5/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............***Failed    0.09 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 6/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........***Failed    0.09 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 7/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........***Failed    0.09 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 8/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....***Failed    0.09 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
 9/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...***Failed    0.04 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
10/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........***Failed    0.04 sec
      Start 18: rrfs_bufr2ioda_msonet
11/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........***Failed    0.04 sec
12/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........***Failed    0.04 sec
13/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........***Failed    0.04 sec
14/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............***Failed    0.04 sec
15/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............***Failed    0.04 sec
16/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........***Failed    0.04 sec
17/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................***Failed    0.04 sec
18/18 Test #18: rrfs_bufr2ioda_msonet .........................***Failed    0.04 sec

0% tests passed, 18 tests failed out of 18

Label Time Summary:
mpi            =   1.16 sec*proc (18 tests)
rdas-bundle    =   1.16 sec*proc (18 tests)
script         =   1.16 sec*proc (18 tests)

Total Test time (real) =   0.20 sec

The following tests FAILED:
	  1 - rrfs_fv3jedi_2024052700_3dvar (Failed)
	  2 - rrfs_fv3jedi_2024052700_3denvar (Failed)
	  3 - rrfs_fv3jedi_2024052700_3denvar_mgbf (Failed)
	  4 - rrfs_fv3jedi_2024052700_hybrid3denvar (Failed)
	  5 - rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf (Failed)
	  6 - rrfs_fv3jedi_2024052700_getkf_observer (Failed)
	  7 - rrfs_fv3jedi_2024052700_getkf_solver (Failed)
	  8 - rrfs_fv3jedi_2024052700_3dvar_conv_surface (Failed)
	  9 - rrfs_fv3jedi_2024052700_3dvar_conv_upperair (Failed)
	 10 - rrfs_fv3jedi_2024052700_3dvar_remote (Failed)
	 11 - rrfs_fv3jedi_2024052700_3dvar_satrad (Failed)
	 12 - rrfs_fv3jedi_2024052700_3denvar_refl (Failed)
	 13 - rrfs_mpasjedi_2024052700_bumploc (Failed)
	 14 - rrfs_mpasjedi_2024052700_3denvar (Failed)
	 15 - rrfs_mpasjedi_2024052700_getkf_observer (Failed)
	 16 - rrfs_mpasjedi_2024052700_getkf_solver (Failed)
	 17 - rrfs_mpasjedi_2024052700_3dvar (Failed)
	 18 - rrfs_bufr2ioda_msonet (Failed)
Errors while running CTest
Output from these tests are in: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532/build/rrfs-test/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532

@SamuelDegelia-NOAA
Copy link
Contributor Author

Seems that there is an issue on Hera. All jobs failed with:

srun: error: Srun communication socket apparently being written to by something other than Slurm

@SamuelDegelia-NOAA
Copy link
Contributor Author

PASSED on wcoss2

started build_and_test on wcoss2 at UTC time: Wed Feb 4 21:19:55 UTC 2026
finished at UTC time: Wed Feb 4 22:12:11 UTC 2026

Test project /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/532/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 1/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   84.06 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 2/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   90.06 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 3/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed  103.05 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 4/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed  107.17 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 5/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed  134.08 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 6/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed  125.98 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 7/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  245.10 sec
      Start 18: rrfs_bufr2ioda_msonet
 8/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  249.06 sec
 9/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   39.72 sec
10/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  291.09 sec
11/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  302.14 sec
12/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed  176.00 sec
13/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed  112.99 sec
14/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  457.07 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
15/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  360.00 sec
16/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  489.14 sec
17/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  668.04 sec
18/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  330.00 sec

100% tests passed, 0 tests failed out of 18

Label Time Summary:
rdas-bundle    = 4364.75 sec*proc (18 tests)
script         = 4364.75 sec*proc (18 tests)

Total Test time (real) = 787.11 sec

workdir: /lfs/h2/emc/da/noscrub/samuel.degelia/rrfsbot/PRs_RDASApp/532

@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 5, 2026

FAILED on hera

started build_and_test on hera at UTC time: Thu Feb 5 01:30:51 UTC 2026
finished at UTC time: Thu Feb 5 01:50:55 UTC 2026

Test project /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
 1/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............***Failed    0.08 sec
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
 2/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........***Failed    0.08 sec
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 3/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........***Failed    0.11 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 4/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....***Failed    0.09 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 5/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........***Failed    0.10 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 6/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................***Failed    0.10 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 7/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....***Failed    0.10 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 8/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......***Failed    0.11 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
 9/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...***Failed    0.04 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
10/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........***Failed    0.04 sec
      Start 18: rrfs_bufr2ioda_msonet
11/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........***Failed    0.04 sec
12/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........***Failed    0.05 sec
13/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............***Failed    0.04 sec
14/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........***Failed    0.05 sec
15/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............***Failed    0.04 sec
16/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........***Failed    0.04 sec
17/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................***Failed    0.04 sec
18/18 Test #18: rrfs_bufr2ioda_msonet .........................***Failed    0.04 sec

0% tests passed, 18 tests failed out of 18

Label Time Summary:
mpi            =   1.20 sec*proc (18 tests)
rdas-bundle    =   1.20 sec*proc (18 tests)
script         =   1.20 sec*proc (18 tests)

Total Test time (real) =   0.21 sec

The following tests FAILED:
	  1 - rrfs_fv3jedi_2024052700_3dvar (Failed)
	  2 - rrfs_fv3jedi_2024052700_3denvar (Failed)
	  3 - rrfs_fv3jedi_2024052700_3denvar_mgbf (Failed)
	  4 - rrfs_fv3jedi_2024052700_hybrid3denvar (Failed)
	  5 - rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf (Failed)
	  6 - rrfs_fv3jedi_2024052700_getkf_observer (Failed)
	  7 - rrfs_fv3jedi_2024052700_getkf_solver (Failed)
	  8 - rrfs_fv3jedi_2024052700_3dvar_conv_surface (Failed)
	  9 - rrfs_fv3jedi_2024052700_3dvar_conv_upperair (Failed)
	 10 - rrfs_fv3jedi_2024052700_3dvar_remote (Failed)
	 11 - rrfs_fv3jedi_2024052700_3dvar_satrad (Failed)
	 12 - rrfs_fv3jedi_2024052700_3denvar_refl (Failed)
	 13 - rrfs_mpasjedi_2024052700_bumploc (Failed)
	 14 - rrfs_mpasjedi_2024052700_3denvar (Failed)
	 15 - rrfs_mpasjedi_2024052700_getkf_observer (Failed)
	 16 - rrfs_mpasjedi_2024052700_getkf_solver (Failed)
	 17 - rrfs_mpasjedi_2024052700_3dvar (Failed)
	 18 - rrfs_bufr2ioda_msonet (Failed)
Errors while running CTest
Output from these tests are in: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532/build/rrfs-test/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.

workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532

@SamuelDegelia-NOAA
Copy link
Contributor Author

Looking into the ctest issue on Hera. But I think this PR is okay since everything is passing on WCOSS2.

@SamuelDegelia-NOAA SamuelDegelia-NOAA marked this pull request as ready for review February 5, 2026 18:10
@rrfsbot
Copy link
Collaborator

rrfsbot commented Feb 6, 2026

PASSED on hera

started build_and_test on hera at UTC time: Fri Feb 6 16:00:28 UTC 2026
finished at UTC time: Fri Feb 6 16:27:51 UTC 2026

Test project /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532/build/rrfs-test
      Start  6: rrfs_fv3jedi_2024052700_getkf_observer
      Start 15: rrfs_mpasjedi_2024052700_getkf_observer
      Start  1: rrfs_fv3jedi_2024052700_3dvar
      Start  2: rrfs_fv3jedi_2024052700_3denvar
      Start  3: rrfs_fv3jedi_2024052700_3denvar_mgbf
      Start  4: rrfs_fv3jedi_2024052700_hybrid3denvar
      Start  5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf
      Start  8: rrfs_fv3jedi_2024052700_3dvar_conv_surface
 1/18 Test  #1: rrfs_fv3jedi_2024052700_3dvar .................   Passed   30.23 sec
      Start  9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair
 2/18 Test  #8: rrfs_fv3jedi_2024052700_3dvar_conv_surface ....   Passed   50.43 sec
      Start 10: rrfs_fv3jedi_2024052700_3dvar_remote
 3/18 Test  #6: rrfs_fv3jedi_2024052700_getkf_observer ........   Passed   57.79 sec
      Start  7: rrfs_fv3jedi_2024052700_getkf_solver
 4/18 Test #10: rrfs_fv3jedi_2024052700_3dvar_remote ..........   Passed   22.83 sec
      Start 11: rrfs_fv3jedi_2024052700_3dvar_satrad
 5/18 Test  #9: rrfs_fv3jedi_2024052700_3dvar_conv_upperair ...   Passed   44.28 sec
      Start 12: rrfs_fv3jedi_2024052700_3denvar_refl
 6/18 Test  #7: rrfs_fv3jedi_2024052700_getkf_solver ..........   Passed   54.42 sec
      Start 13: rrfs_mpasjedi_2024052700_bumploc
 7/18 Test  #2: rrfs_fv3jedi_2024052700_3denvar ...............   Passed  122.08 sec
      Start 14: rrfs_mpasjedi_2024052700_3denvar
 8/18 Test #11: rrfs_fv3jedi_2024052700_3dvar_satrad ..........   Passed   58.63 sec
      Start 17: rrfs_mpasjedi_2024052700_3dvar
 9/18 Test  #5: rrfs_fv3jedi_2024052700_hybrid3denvar_mgbf ....   Passed  159.55 sec
      Start 18: rrfs_bufr2ioda_msonet
10/18 Test  #3: rrfs_fv3jedi_2024052700_3denvar_mgbf ..........   Passed  165.63 sec
11/18 Test  #4: rrfs_fv3jedi_2024052700_hybrid3denvar .........   Passed  169.53 sec
12/18 Test #15: rrfs_mpasjedi_2024052700_getkf_observer .......   Passed  182.07 sec
      Start 16: rrfs_mpasjedi_2024052700_getkf_solver
13/18 Test #17: rrfs_mpasjedi_2024052700_3dvar ................   Passed   50.27 sec
14/18 Test #18: rrfs_bufr2ioda_msonet .........................   Passed   25.81 sec
15/18 Test #16: rrfs_mpasjedi_2024052700_getkf_solver .........   Passed  170.81 sec
16/18 Test #14: rrfs_mpasjedi_2024052700_3denvar ..............   Passed  262.78 sec
17/18 Test #12: rrfs_fv3jedi_2024052700_3denvar_refl ..........   Passed  341.29 sec
18/18 Test #13: rrfs_mpasjedi_2024052700_bumploc ..............   Passed  304.96 sec

100% tests passed, 0 tests failed out of 18

Label Time Summary:
mpi            = 2273.39 sec*proc (18 tests)
rdas-bundle    = 2273.39 sec*proc (18 tests)
script         = 2273.39 sec*proc (18 tests)

Total Test time (real) = 417.20 sec

workdir: /scratch3/NCEPDEV/fv3-cam/rrfsbot/PRs_RDASApp/532

@ShunLiu-NOAA ShunLiu-NOAA merged commit 184d30a into NOAA-EMC:develop Feb 6, 2026
1 check passed
@SamuelDegelia-NOAA SamuelDegelia-NOAA deleted the feature/udpate_jcb_for_enkf_wflow branch February 6, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants