Open
Conversation
…HINE_ID and fix passing DEBUG to CICE6
Contributor
|
@MinsukJi-NOAA. I do not have time for this review. Could you please request Bin instead? |
MinsukJi-NOAA
requested review from
binli2337
and removed request for
DeniseWorthen
Contributor
|
@MinsukJi-NOAA @arunchawla-NOAA Thanks Minsuk |
Author
|
Please consider asking Shan Sun to review. |
| @@ -1,4 +1,4 @@ | |||
|
|
|||
| NCP="/bin/cp" | |||
Collaborator
There was a problem hiding this comment.
Why do we need this? Is cp not working?
Collaborator
Author
|
Yes, it wasn't working at some point.
Moorthi
…On Tue, Aug 25, 2020 at 9:21 AM Jun Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/incmake/configure_rules.mk
<#79 (comment)>:
> @@ -1,4 +1,4 @@
-
+NCP="/bin/cp"
Why do we need this? Is cp not working?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#79 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYT6D32PZUVSO62YTXDSCO2IFANCNFSM4QKQSLLA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Author
|
They have been removed
Moorthi
…On Tue, Aug 25, 2020 at 9:23 AM Jun Wang ***@***.***> wrote:
Moorthi,
There are many mediator.F90 files, please remote those temporary ones.
- *M* src/module_MEDIATOR.F90
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-194a7ece4d5d56662ed3f7b456d879df
>
(8143)
- *A* src/module_MEDIATOR.F90_Jun01
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-ef85779e08bede82317a87ca8343edd6
>
(9917)
- *A* src/module_MEDIATOR.F90_Jun08
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-b041c8eb3054c058261442fefdb2325d
>
(9917)
- *A* src/module_MEDIATOR.F90_feb13
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-f5763ed610b670f906eff71e2ea720a9
>
(9869)
- *A* src/module_MEDIATOR.F90_feb22
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-e72f3d9e8d41a199c58ab4d70421c7c0
>
(9904)
- *A* src/module_MEDIATOR.F90_feb24
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-0ee634fc7cc0b3dbb9a3a9b47e0eaf9e
>
(9922)
- *A* src/module_MEDIATOR.F90_landmask
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-5fc2201f4855bfe30b0ccba9e6905b1d
>
(9931)
- *A* src/module_MEDIATOR.F90_orig
<
https://github.com/NOAA-EMC/NEMS/pull/79/files#diff-7ba0c6e30b8845a0cca0cee14009bef5
>
(8957)
On Tue, Aug 25, 2020 at 9:04 AM SMoorthi-emc ***@***.***>
wrote:
> Please consider asking Shan Sun to review.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <#79 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AI7D6TM74CUO7KBJHHXY7BDSCOY67ANCNFSM4QKQSLLA
>
> .
>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#79 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYR7LXYEPBY5E3WWCL3SCO2OLANCNFSM4QKQSLLA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
ShanSunNOAA
approved these changes
Aug 25, 2020
Collaborator
ShanSunNOAA
left a comment
ShanSunNOAA
left a comment
There was a problem hiding this comment.
All look to me. Thanks Moorthi for doing these much-needed cleanup. -Shan
Collaborator
|
@SMoorthi-emc, if you have run the regression tests for the weather and s2s model, please let us know.That will help with the merging process. |
Author
|
No, I haven't.
…On Fri, Aug 28, 2020 at 9:12 AM Minsuk Ji ***@***.***> wrote:
@SMoorthi-emc <https://github.com/SMoorthi-emc>, if you have run the
regression tests for the weather and s2s model, please let us know.That
will help with the merging process.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#79 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYQK3UCEQUDHLHIDVYDSC6UNFANCNFSM4QKQSLLA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Collaborator
|
Do we need these compile_*.sh files under NEMS? |
Author
|
No. I had it before we had the current compile.sh. I will remove.
…On Fri, Aug 28, 2020 at 9:33 AM Minsuk Ji ***@***.***> wrote:
Do we need these compile_*.sh files under NEMS?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#79 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYVCAFULUT3THQAPTCDSC6W2DANCNFSM4QKQSLLA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Collaborator
Given the amount of clean up/code changes, we should probably run the regression tests for both weather and s2s. |
Author
|
I guess there are no regressions tests with NEMS mediator anymore right?
The NEMS mediator does change results because it now works for both
fractional and non-fractional grids.
However, there are no changes affecting CMEPS, except that the coupled
executable compiled with CMEPS can now be used to run standalone FV3.
…On Fri, Aug 28, 2020 at 9:38 AM Minsuk Ji ***@***.***> wrote:
No, I haven't.
Given the amount of clean up/code changes, we should probably run the
regression tests for both weather and s2s.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#79 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLVRYXBUI7QC34ALWHBOP3SC6XN3ANCNFSM4QKQSLLA>
.
--
Dr. Shrinivas Moorthi
Research Meteorologist
Modeling and Data Assimilation Branch
Environmental Modeling Center / National Centers for Environmental
Prediction
5830 University Research Court - (W/NP23), College Park MD 20740 USA
Tel: (301)683-3718
e-mail: [email protected]
Phone: (301) 683-3718 Fax: (301) 683-3718
|
Collaborator
|
@SMoorthi-emc, can we close this PR? |
Author
|
Why? |
Collaborator
|
Moorthi, it wasn't clear to me since it has been some time and we have moved from NEMS to CMEPS. Please let me know if I am mistaken, and/or what your plans are regarding this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have many changes in NEMS that should make it leaner and cleaner.
I am putting this pull request as suggested by Arun for consideration.