Apply land fraction as land mask for IMS snow depth preprocessing#2079
Open
jiaruidong2017 wants to merge 2 commits intodevelopfrom
Open
Apply land fraction as land mask for IMS snow depth preprocessing#2079jiaruidong2017 wants to merge 2 commits intodevelopfrom
jiaruidong2017 wants to merge 2 commits intodevelopfrom
Conversation
Remove derived IMS obs over landice Add a low bound to snow density
| std::max(80.0, std::min(120.0, tmp_density)) / 1000.0; | ||
| } | ||
| // where (density < 0.0001) density = 0.08 | ||
| if (bkg_density(jnode, 0) < 0.0001) { |
Contributor
There was a problem hiding this comment.
is there any concern about something above 0.001 but below 0.08?
Collaborator
Author
There was a problem hiding this comment.
This follows the implementation in original IMSproc repo as below:
https://github.com/NOAA-EMC/land-SCF_proc/blob/19957e5160f4793076d81549ffe88c17e1377583/sorc/IMSaggregate_mod.f90#L856
I agree that we can modify the logic so that if snow density is less than 0.08, it is reset to 0.08. After receiving confirmation from you and @ClaraDraper-NOAA, I will proceed with the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of the code changes in this PR:
Issues
Resolves #2078
Automated CI tests to run in Global Workflow