Skip to content

EVS Bugfix for incorrect formatted hourly AIRNOW OBS for RRFS-CHEM grid2obs and message clean-up#724

Open
Ho-ChunHuang-NOAA wants to merge 11 commits intoNOAA-EMC:feature/rrfs_refs_v1from
Ho-ChunHuang-NOAA:feature/rrfs_airnow_bugfix
Open

EVS Bugfix for incorrect formatted hourly AIRNOW OBS for RRFS-CHEM grid2obs and message clean-up#724
Ho-ChunHuang-NOAA wants to merge 11 commits intoNOAA-EMC:feature/rrfs_refs_v1from
Ho-ChunHuang-NOAA:feature/rrfs_airnow_bugfix

Conversation

@Ho-ChunHuang-NOAA
Copy link
Contributor

@Ho-ChunHuang-NOAA Ho-ChunHuang-NOAA commented May 12, 2025

Note to developers: You must use this PR template!

Description of Changes

Please include a summary of the changes and the related GitHub issue(s). Please also include relevant motivation and context.

Please note this revision is to merge back to NOAA-EMC/EVS branch feature/rrfs-refs_v1 NOT DEVELOP. If there is an question on the merge please consult with Perry who previously has handled RRFS-CHEM PR.

This PR is to provide NCO bugfix for incorrect formatted AIRNOW input for RRFS-Chem that is similar to PR#710 plus sendmail clean-up as that of #PR715.

This is to resolve Fix and Addition v2.0 requirement for RRFS-Chem.

Developer Questions and Checklist

  • Is this a high priority PR? If so, why and is there a date it needs to be merged by?
    NO

  • Do you have any planned upcoming annual leave/PTO?
    NO

  • Are there any changes needed in the times when the jobs are supposed to run/kick-off?
    NO

  • [X ] The code changes follow NCO's EE2 Standards.
  • [ X] Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • [ X] References the feature branch for HOMEevs are removed from the code.
  • [X ] J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • [X ] Jobs over 15 minutes in runtime have restart capability.
  • [X ] If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • [ X] Jobs contain the appropriate file checking and don't run METplus for any missing data.
  • [X ] Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.
    Allows WARNING message for missing dcom input file

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.

Download feature/rrfs_airnow_bugfix to local working branch.

(a) Test for normal operation, please run the prep and stats for today, i.e., default to PDYm3. Should not find and error and warning messages.

 (a.1) ~/dev/drivers/scripts/prep/cam/jevs_cam_rrfs_chem_grid2obs_prep.sh
 (a.2) ~/dev/drivers/scripts/stats/cam/
      jevs_cam_rrfs_chem_grid2obs_aeronet_aod_stats.sh  
      jevs_cam_rrfs_chem_grid2obs_airnow_pm25_stats.sh
      jevs_cam_rrfs_chem_grid2obs_airnow_pm10_stats.sh
      run vhr=00-22 first (can be run together), after 00-22 are done, run vhr=23.

Add statements, export COMINrrfs=/lfs/h2/emc/ptmp/emc.lam/com/rrfs/v1.0 in (a.1) and (a.2)

(b) Test April 4 failure.

 (b.1) ~/dev/drivers/scripts/prep/cam/jevs_cam_rrfs_chem_grid2obs_prep.sh
 Add statements,
      export DCOMINairnow=/lfs/h2/emc/vpppg/noscrub/ho-chun.huang/dcom/prod/airnow
      export INITDATE=20250401

(c) Test sendmail message only for corrupt and missing dcom input file

 (c.1) Remove PR test EVS prep output generated in (a.1) (b.1)
 (c.2) Repeat (b.1) with "export INITDATE=20250401", but without "export DCOMINairnow=......." 
 (c.3) Repeat (a.2) with statement of export VDATE=20250401, but without "export COMINrrfs=...."

@AliciaBentley-NOAA
Copy link
Contributor

@Ho-ChunHuang-NOAA Does this PR from May 2025 need to stay open? Or can it be closed and potentially added to EVS v2.0+ later?

CC @malloryprow @AndrewBenjamin-NOAA

@Ho-ChunHuang-NOAA
Copy link
Contributor Author

@AliciaBentley-NOAA Please check the email of Feb 4 2026 titled "Close EVS PR for RRFS-Chem". Andrew wants to keep PR #724" opened. Please consult with him for further actions.

"Hi Ho-Chun,

After my meeting with Jason yesterday, I suggest you do not remove your RRFS-Chem code in the feature/rrfs_refs_v1 branch. We are not using that feature branch for the RRFS/REFS EVSv.2.0.x code delivery, so there is no harm in leaving it there, and I like that the code is on github as a starting point for the future.

Also, after speaking with Jason about this topic yesterday, we need to put a hold (at least for now) on developing RRFS-chem and getting into operations. There may be a space for it in EVSv2.1, but with the moratorium looming, NCO only has enough SPAs to handle the large code deliveries (GFS, RRFS) before the end of the year. It is not a given that NCO will be able to handle any more EVS code deliveries than what we already have scheduled. Alicia, Saeideh, Jason and I will have to coordinate and prioritize what component updates will get into EVSv2.1. RRFS-Chem may or may not be a part of that delivery, there is still discussion to be had on that.

So for now, I think the best thing to do is leave things as they are, and we can have more discussion on where RRFS-chem fits into EVS.

Thank you again for beginning this discussion yesterday,

Andrew
"

ccing @AndrewBenjamin-NOAA @malloryprow @sbanihash

@malloryprow
Copy link
Contributor

malloryprow commented Mar 2, 2026

Could we close the PR but you keep your feature branch in your fork? The work won't be lost if the PR is closed but you keep your feature branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants