EVS Bugfix for incorrect formatted hourly AIRNOW OBS for RRFS-CHEM grid2obs and message clean-up#724
Conversation
|
@Ho-ChunHuang-NOAA Does this PR from May 2025 need to stay open? Or can it be closed and potentially added to EVS v2.0+ later? |
|
@AliciaBentley-NOAA Please check the email of Feb 4 2026 titled "Close EVS PR for RRFS-Chem". Andrew wants to keep PR #724" opened. Please consult with him for further actions. "Hi Ho-Chun, After my meeting with Jason yesterday, I suggest you do not remove your RRFS-Chem code in the feature/rrfs_refs_v1 branch. We are not using that feature branch for the RRFS/REFS EVSv.2.0.x code delivery, so there is no harm in leaving it there, and I like that the code is on github as a starting point for the future. Also, after speaking with Jason about this topic yesterday, we need to put a hold (at least for now) on developing RRFS-chem and getting into operations. There may be a space for it in EVSv2.1, but with the moratorium looming, NCO only has enough SPAs to handle the large code deliveries (GFS, RRFS) before the end of the year. It is not a given that NCO will be able to handle any more EVS code deliveries than what we already have scheduled. Alicia, Saeideh, Jason and I will have to coordinate and prioritize what component updates will get into EVSv2.1. RRFS-Chem may or may not be a part of that delivery, there is still discussion to be had on that. So for now, I think the best thing to do is leave things as they are, and we can have more discussion on where RRFS-chem fits into EVS. Thank you again for beginning this discussion yesterday, Andrew |
|
Could we close the PR but you keep your feature branch in your fork? The work won't be lost if the PR is closed but you keep your feature branch. |
Note to developers: You must use this PR template!
Description of Changes
Please note this revision is to merge back to NOAA-EMC/EVS branch feature/rrfs-refs_v1 NOT DEVELOP. If there is an question on the merge please consult with Perry who previously has handled RRFS-CHEM PR.
This PR is to provide NCO bugfix for incorrect formatted AIRNOW input for RRFS-Chem that is similar to PR#710 plus sendmail clean-up as that of #PR715.
This is to resolve Fix and Addition v2.0 requirement for RRFS-Chem.
Developer Questions and Checklist
Is this a high priority PR? If so, why and is there a date it needs to be merged by?
NO
Do you have any planned upcoming annual leave/PTO?
NO
Are there any changes needed in the times when the jobs are supposed to run/kick-off?
NO
${USER}where necessary throughout the code.HOMEevsare removed from the code.dev/drivers/scriptsordev/modulefileshave been made in the correspondingecf/scriptsandecf/defs/evs-nco.def?Allows WARNING message for missing dcom input file
Testing Instructions
Download feature/rrfs_airnow_bugfix to local working branch.
(a) Test for normal operation, please run the prep and stats for today, i.e., default to PDYm3. Should not find and error and warning messages.
Add statements, export COMINrrfs=/lfs/h2/emc/ptmp/emc.lam/com/rrfs/v1.0 in (a.1) and (a.2)
(b) Test April 4 failure.
(c) Test sendmail message only for corrupt and missing dcom input file