Skip to content

Make add_increment build conditional on fv3jedi availability#71

Merged
CoryMartin-NOAA merged 2 commits intodevelopfrom
copilot/fix-cmake-increment-build
Jan 21, 2026
Merged

Make add_increment build conditional on fv3jedi availability#71
CoryMartin-NOAA merged 2 commits intodevelopfrom
copilot/fix-cmake-increment-build

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 21, 2026

The add_increment subdirectory was built whenever oops was found, but it requires the fv3jedi library. This caused build failures in environments where fv3jedi is unavailable (e.g., ObsForge).

Changes

  • Added find_package(fv3jedi) to main CMakeLists.txt
  • Gated add_subdirectory(add_increment) on fv3jedi_FOUND in src/CMakeLists.txt
if ( oops_FOUND )
  # ... other subdirectories ...
  if ( fv3jedi_FOUND )
    add_subdirectory( add_increment )
  endif()
endif()

The add_increment tools now build only when both dependencies are available.

Original prompt

This section details on the original issue you should resolve

<issue_title>FV3-JEDI add increment needs to only be build if FV3-JEDI is found</issue_title>
<issue_description>

add_subdirectory( add_increment )

This will fail if we try to build as part of ObsForge, for example...

It should only include this subdirectory in the CMake if the fv3jedi library is found</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…g found

Co-authored-by: CoryMartin-NOAA <6354668+CoryMartin-NOAA@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CMake build for FV3-JEDI increment check Make add_increment build conditional on fv3jedi availability Jan 21, 2026
Copilot AI requested a review from CoryMartin-NOAA January 21, 2026 15:39
@CoryMartin-NOAA CoryMartin-NOAA marked this pull request as ready for review January 21, 2026 15:40
@CoryMartin-NOAA CoryMartin-NOAA merged commit 283d0ed into develop Jan 21, 2026
1 check passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the copilot/fix-cmake-increment-build branch January 21, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FV3-JEDI add increment needs to only be build if FV3-JEDI is found

3 participants