Add add increment application with variable change capability#67
Merged
CoryMartin-NOAA merged 5 commits intodevelopfrom Jan 14, 2026
Merged
Add add increment application with variable change capability#67CoryMartin-NOAA merged 5 commits intodevelopfrom
CoryMartin-NOAA merged 5 commits intodevelopfrom
Conversation
|
@DavidNew-NOAA thank you so much for already moving this code here! I'm still learning how to use the version of this code from GDASApp, but I suspect this will be what we want to use going forward. I hope RDASApp will soon add this repo as a submodule. |
CoryMartin-NOAA
approved these changes
Jan 14, 2026
Contributor
Author
|
CI actually failed I just noticed. Can't find
I need to look into this tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates two FV3-JEDI applications, both are versions of the general JEDI AddIncrement application. Both applications use the same header file, which adds the option to perform a variable change after adding the increment. This is useful if, for example, the background state contains
psanddelp, but the increment only containsdelp.psis derivable fromdelp, so the variable change allows you to recalculatepsbased on the newdelpafter increment addition.One application is a conventional JEDI application while the other is an ensemble application (used in Global Workflow for ensemble recentering.)