Skip to content

Add add increment application with variable change capability#67

Merged
CoryMartin-NOAA merged 5 commits intodevelopfrom
feature/add_increment
Jan 14, 2026
Merged

Add add increment application with variable change capability#67
CoryMartin-NOAA merged 5 commits intodevelopfrom
feature/add_increment

Conversation

@DavidNew-NOAA
Copy link
Copy Markdown
Contributor

@DavidNew-NOAA DavidNew-NOAA commented Jan 14, 2026

This PR creates two FV3-JEDI applications, both are versions of the general JEDI AddIncrement application. Both applications use the same header file, which adds the option to perform a variable change after adding the increment. This is useful if, for example, the background state contains ps and delp, but the increment only contains delp. ps is derivable from delp, so the variable change allows you to recalculate ps based on the new delp after increment addition.

One application is a conventional JEDI application while the other is an ensemble application (used in Global Workflow for ensemble recentering.)

Comment thread src/add_increment/CMakeLists.txt Outdated
@delippi
Copy link
Copy Markdown

delippi commented Jan 14, 2026

@DavidNew-NOAA thank you so much for already moving this code here! I'm still learning how to use the version of this code from GDASApp, but I suspect this will be what we want to use going forward. I hope RDASApp will soon add this repo as a submodule.

@CoryMartin-NOAA CoryMartin-NOAA merged commit 9113c30 into develop Jan 14, 2026
1 check failed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/add_increment branch January 14, 2026 21:18
@DavidNew-NOAA
Copy link
Copy Markdown
Contributor Author

CI actually failed I just noticed. Can't find

#include "fv3jedi/Utilities/Traits.h"

I need to look into this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants