Add SAVE_UNMASKED_GEOM_FILE option #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to skip creating the unmasked MOM domain that could be saved in the geometry file.
|
@theresa-cordero, thanks for the prompt action! The code changes look good at a glance, and I believe they should work. Unfortunately, recent OBC-related changes on the MOM6 side have altered the NWA12K baselines (even without the most recent commit). I'm currently trying to identify which PR(s) are the root cause—possibly multiple ones. I'll need to hold off a bit before merging this one. |
yichengt900
approved these changes
May 21, 2025
yichengt900
left a comment
yichengt900
left a comment
There was a problem hiding this comment.
The baseline change appears to be caused by the recent ocean_BGC tag update—not by changes on the MOM6 side in the CEFI-regional-mom6 draft tag update PR.
This PR resolves the mask_table issue for the NEP domain. Approved.
yichengt900
merged commit 1582e23
into
NOAA-CEFI-Regional-Ocean-Modeling:dev/cefi
52 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to skip creating the unmasked MOM domain that could be saved in the geometry file.
The option to include an unmasked domain was introduced in MOM6 recently but creates a problem for some CEFI configurations (notably the NEP). When false, this flag skips the generation of the unmasked ocean domain that was creating the issue.