Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls-supported-groups SvcParam support #236

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

wtoorop
Copy link
Member

@wtoorop wtoorop commented Nov 8, 2024

As specified in https://datatracker.ietf.org/doc/draft-ietf-tls-key-share-prediction/01/

Also:

  • draft-ietf-ohai-svcb-config became RFC 9540 for the ohttp SvcParam
  • added tests for ohttp

From https://datatracker.ietf.org/doc/draft-ietf-tls-key-share-prediction/01/
Also:
- draft-ietf-ohai-svcb-config became RFC 9540 for the ohttp SvcParam
- added tests for ohttp
@wtoorop wtoorop requested a review from k0ekk0ek November 8, 2024 12:11
src/generic/svcb.h Outdated Show resolved Hide resolved
@wtoorop wtoorop requested a review from wcawijngaards November 8, 2024 13:24
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review comment was already resolved. Thank you for the quick fix!

src/generic/parser.h Outdated Show resolved Hide resolved
@k0ekk0ek
Copy link
Contributor

@wtoorop, looks mostly good to me. Just the one remark.

So SIMD cmpeq on mnemonics keeps working as intended
@wtoorop wtoorop requested a review from k0ekk0ek November 12, 2024 13:41
@wtoorop wtoorop self-assigned this Nov 12, 2024
@wtoorop wtoorop merged commit 0411158 into main Nov 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants