Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make compilation of objects depend on export header #218

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Make compilation of objects depend on export header #218

merged 2 commits into from
Jul 19, 2024

Conversation

k0ekk0ek
Copy link
Contributor

Should fix #216.

@k0ekk0ek k0ekk0ek requested a review from wcawijngaards July 19, 2024 08:08
wcawijngaards
wcawijngaards approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to have this change. Making the object files depend on the header should make the header before those object files.

k0ekk0ek added 2 commits July 19, 2024 10:30
@k0ekk0ek
Remove export header in clean target
6223271
@k0ekk0ek
Make objects depend on export header
94dd8a0 
NSD builds in Gentoo use --shuffle to randomly alter build order to test
target dependencies. As the export header was a dependency of the link
target and not the objects the export header might not be available
during compilation.

Fixes NLnetLabs#216.
@k0ekk0ek k0ekk0ek force-pushed the every-build-im-shuffling branch 2 times, most recently from db42a58 to 94dd8a0 Compare July 19, 2024 08:36
@k0ekk0ek k0ekk0ek mentioned this pull request Jul 19, 2024
Closed
@k0ekk0ek k0ekk0ek merged commit 0f12b58 into NLnetLabs:main Jul 19, 2024
11 checks passed
@k0ekk0ek k0ekk0ek deleted the every-build-im-shuffling branch July 19, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcawijngaards wcawijngaards wcawijngaards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

include/zone/export.h may not get created if GNU make uses --shuffle mode
2 participants
@k0ekk0ek @wcawijngaards