Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Developer Studio 12.6 fixes #201

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Conversation

k0ekk0ek
Copy link
Contributor

The compiler has problems with getopt (not technically necessary for NSD), so the configure checks need to be extended a little bit. Apart from that, the functions need unit tests to verify they do exactly as required because and to verify they don't introduce extra work. Work-in-progress.

@k0ekk0ek
Copy link
Contributor Author

Compile under Oracle Developer Studio 12.6 still fails because tempnam is missing. It's used only in tests, but we needed to use another function for that because of warnings anyway, so fixing that next. Still need to add tests to verify correct operation of lower level functions like trailing_zeroes etc.

@k0ekk0ek
Copy link
Contributor Author

k0ekk0ek commented Jul 1, 2024

Well it builds and runs if I compile using Oracle Developer Studio 12.6. Now to add tests etc.

@k0ekk0ek k0ekk0ek force-pushed the sunpro-fixes branch 2 times, most recently from c70b3c7 to a682841 Compare July 2, 2024 09:20
@k0ekk0ek
Copy link
Contributor Author

k0ekk0ek commented Jul 2, 2024

Still some warnings when compiling with developer studio, but builds and tests all run.

@k0ekk0ek k0ekk0ek force-pushed the sunpro-fixes branch 5 times, most recently from eb1bc32 to 1af322f Compare July 3, 2024 08:40
@k0ekk0ek
Copy link
Contributor Author

Changes so far allow me to build for Solaris 10 (sparce and x86_64). Now going to test building NSD 4.10.

@k0ekk0ek
Copy link
Contributor Author

Once NLnetLabs/nsd#351 is merged, simdzone compiles just fine. At least, with GCC. simdzone builds just fine with Developer Studio 12.4 too, but NSD itself does not. Verified for x86 and Sparc using build infrastructure from https://www.opencsw.org/.

See log:
solaris.build.log

@k0ekk0ek k0ekk0ek marked this pull request as ready for review July 12, 2024 09:11
@k0ekk0ek k0ekk0ek requested a review from wcawijngaards July 12, 2024 09:12
@k0ekk0ek
Copy link
Contributor Author

Quick push to resolve merge issues. Should be all good now.

Copy link
Member

@wcawijngaards wcawijngaards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many changes, but it is nice to increase the portability. There are added tests for the compat simd implementations.

tests/bounds.c Show resolved Hide resolved
tests/fallback/bits.c Outdated Show resolved Hide resolved
tests/haswell/bits.c Outdated Show resolved Hide resolved
tests/westmere/bits.c Outdated Show resolved Hide resolved
@k0ekk0ek k0ekk0ek force-pushed the sunpro-fixes branch 2 times, most recently from bb532da to b471068 Compare July 16, 2024 13:48
@k0ekk0ek k0ekk0ek merged commit d57b043 into NLnetLabs:main Jul 17, 2024
6 checks passed
@k0ekk0ek k0ekk0ek deleted the sunpro-fixes branch July 19, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants