Cleanup interface and code, add new base16 decoder, etc #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes exposing the type and field information externally, thereby simplifying the code. It also adds the High performance base16 decoder from client9. Most importantly, it simplifies the SIMD and fallback scanners by adopting a slightly different interface and updates a lot of individual parser functions.
A lot of the code was more-or-less:
First the
lex
function would classify the type of token (e.g.<contiguous>
,<quoted>
,<line-feed>
or<end-of-file>
) to correctly set pointer and length, after which theparse_yyy
andparse_zzz
functions would check again to ensure proper syntax. In zone files though, often times we know exactly what type to expect and I've opted to remove the checks from the parse functions and simply do them in one go:Leading to ~4% faster code.
Needs more testing etc before merging to main.