Off-by-one error in tls-supported-groups parsing

NLnetLabs · Nov 8, 2024 · 0a7201e · 0a7201e
1 parent c1acc4c
commit 0a7201e
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/generic/svcb.h b/src/generic/svcb.h
@@ -404,8 +404,10 @@ static int32_t parse_tls_supported_groups(
       if (memcmp(g, &group, 2) == 0)
         SEMANTIC_ERROR(parser, "Duplicate group in tls-supported-groups in %s", NAME(type));
     }
-    if (*t++ != ',')
+    if (*t != ',')
       break;
+    else
+      t++;
   }
 
   if (t != te || rdata->octets > rdata->limit)