Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set persist-credentials: false per zizmor suggestion #413

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

maertsen
Copy link
Member

I don't think we currently have anything in CI that needs the (readonly) checkout credentials persisted to .git/config during the run.

@maertsen maertsen requested a review from gthess December 13, 2024 13:06
@gthess gthess requested review from wtoorop and removed request for gthess December 13, 2024 13:23
Copy link
Member

@wtoorop wtoorop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, so please go ahead and merge

@maertsen maertsen merged commit 149049c into master Dec 20, 2024
7 checks passed
@maertsen maertsen deleted the zizmor-improvements branch December 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants