add data validation and error logging - #83
Merged
Conversation
yuqiong77
requested review from
cmaynard-ngwpc
and
a lite review from Copilot
and removed request for
Copilot
August 12, 2026 15:00
cmaynard-ngwpc
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added streamflow data validation and error logging across multiple scripts (
search.py,calibration_set.py,configuration.py, andvalidation_run.py). The changes detect missing or invalid streamflow data early in the calibration/validation workflow and provide meaningful diagnostic information when valid data are unavailable for metric calculation. This allows data-related issues to be identified and reported within nwm-cal-mgr, rather than surfacing later as errors in nwm_metrics within nwm-eval-mgr.See more details at: https://jira.nextgenwaterprediction.com/browse/NGWPC-11595