Skip to content

Ngwpc 11078 11080 subsetting error#99

Merged
danielcumpton merged 3 commits into
mainfrom
NGWPC-11078_11080_subsetting_error
Jul 2, 2026
Merged

Ngwpc 11078 11080 subsetting error#99
danielcumpton merged 3 commits into
mainfrom
NGWPC-11078_11080_subsetting_error

Conversation

@danielcumpton

Copy link
Copy Markdown

[Short description explaining the high-level reason for the pull request]

Additions

If a gage is on a single flowpath with no up or downstream flowpaths, it won't get subset because it's not part of the graph. In this case, the subset can be done using the single flowpath id. Added code to handle the case where the flowpath id is not found in the graph then checking to see if the flowpath exists and if it's standalone. Then subset using just the single flowpath.

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@danielcumpton
danielcumpton requested a review from dylanlee July 2, 2026 17:13
@danielcumpton danielcumpton self-assigned this Jul 2, 2026
@danielcumpton
danielcumpton merged commit 0fb6f8e into main Jul 2, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants