Skip to content

change max character limit for site_no in the streamflow endpoints fr…#98

Merged
dylanlee merged 1 commit into
mainfrom
NGWPC-11079_streamflow_gageid_length
Jun 29, 2026
Merged

change max character limit for site_no in the streamflow endpoints fr…#98
dylanlee merged 1 commit into
mainfrom
NGWPC-11079_streamflow_gageid_length

Conversation

@danielcumpton

Copy link
Copy Markdown

For the streamflow observations endpoints, the max length of the site_id field needed to be change from 10 to 15 to allow gage 402114105350101.

Additions

Removals

Changes

Change max_length in the streamflow observation router file from 10 to 15.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@danielcumpton
danielcumpton requested a review from dylanlee June 29, 2026 15:44
@danielcumpton danielcumpton self-assigned this Jun 29, 2026
@dylanlee
dylanlee merged commit d928d36 into main Jun 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants