Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: calendar): fix calendar standard/daylight date bug #872

Closed
wants to merge 1 commit into from
Closed

fix(module: calendar): fix calendar standard/daylight date bug #872

wants to merge 1 commit into from

Conversation

jirigalis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

2nd of April is displayed twice when AEDT timezone is used. The 2nd of April is the day when AEDT time is changed to AEST, which leads to incorrect number of hours added to the currentDay variable (24 instead of 25). The bug was identified in the datepicker.base.component.ts file on lie 117.

Issue Number: #866

What is the new behavior?

One hour is added (or subtracted) to the currentDay variable when necessary (AEDT to AEST, AEST to AEDT).

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@fisherspy
Copy link
Collaborator

#874 fixes your issue.

@fisherspy fisherspy closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants