fix(baseline): populate executable identity for all platform assets - #4
Merged
Merged
Conversation
software_status fails closed when the baseline has no executable identity for the selected asset (commit ae54f97). The baseline only declared the executable sub-dict for darwin-arm64; the other five assets had none, so every non-darwin-arm64 install reported baseline_executable_unavailable drift and install-cli failed: MiMo Code software install did not produce current target-owned software Populate the executable identity (path, archive_mode, installer_mode, size, sha256) for all five remaining assets by extracting the mimo binary from each pinned release archive and hashing it. The installer already validates these, so wrong values fail loudly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
install-clifailed on every non-darwin-arm64 platform with:Root cause
Commit
ae54f97madesoftware_statusfail closed when the baseline has noexecutableidentity for the selected asset. The baseline only declared theexecutablesub-dict fordarwin-arm64; the other five assets (darwin-x64,darwin-x64-baseline,linux-arm64,linux-x64,linux-x64-baseline) had none, socurrentwas alwaysFalseand install-cli's post-install status check tripped.Fix
Populate the
executableidentity (path,archive_mode,installer_mode,size,sha256) for all five remaining assets by extracting themimobinary from each pinned release archive and hashing it. All archive SHAs verified against their pins. The installer already validates these values, so wrong values fail loudly.Verification
python3 scripts/run_harnesses.py --module nddev-mimocode-app --lane fast # PASS