fix(builder): resolve .claude-plugin marketplace local sources at the repo root (0.3.11) - #22
Merged
Merged
Conversation
… repo root (0.3.11) Codex derives the marketplace root by stripping the recognized manifest layout (marketplace_root_from_layout) and resolves `./`-relative local plugin sources against that root. The checker mirrored this for `.agents/plugins/` but treated a `.claude-plugin/marketplace.json` root as the `.claude-plugin/` directory itself, so a valid local source resolved one level too deep and was reported missing. Resolve `.claude-plugin/` catalogs relative to the directory that contains them. Advance the builder plugin to 0.3.6 and the module to 0.3.11. Claude-Session: https://claude.ai/code/session_01Y29c9sJRhChvxDcUjab5Xo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A final correctness follow-up to 0.3.10, verified against
openai/codexrust-v0.144.6(marketplace_root_from_layout/resolve_local_plugin_source_path).Fixed
Codex resolves
./-relative local plugin sources against the marketplace root — the directory that contains the recognized manifest layout. The checker did this for.agents/plugins/marketplace.json(root = 3 levels up) but treated a.claude-plugin/marketplace.jsonroot as the.claude-plugin/directory itself, so a valid local source resolved one level too deep and was reported missing. Now.claude-plugin/catalogs resolve relative to the directory that contains them, exactly as Codex does..agents/plugins/behavior is unchanged.Builder plugin → 0.3.6, module → 0.3.11. Verified: a
.claude-plugin/marketplace.jsonwith a./plugins/<name>local source now validates;.agents/plugins/unchanged; 53 builder tests pass in the private harness.https://claude.ai/code/session_01Y29c9sJRhChvxDcUjab5Xo