fix(anchor): declare git-submodule consumption alongside runtime-service - #45
Closed
rldyourmnd wants to merge 2 commits into
Closed
fix(anchor): declare git-submodule consumption alongside runtime-service#45rldyourmnd wants to merge 2 commits into
rldyourmnd wants to merge 2 commits into
Conversation
The control plane pins this repository as a gitlink and declares both git-submodule-consumer and workflow-module-consumer relationships, but the module contract enumerated only runtime-service. A planner reading module.consumption therefore got a different dependency model from .gitmodules. Declare both modes: git-submodule for the physical gitlink, runtime-service for reusable-workflow execution from this repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The control plane pins this repository as a gitlink and declares both
git-submodule-consumerandworkflow-module-consumerrelationships, but the module contract enumerated onlyruntime-service. Any planner or agent readingmodule.consumptionas authoritative therefore got a different dependency model from.gitmodules.Declare both modes:
git-submodulefor the physical gitlink,runtime-servicefor reusable-workflow execution from this repository.The control plane now enforces this from its side too:
GDS_IDENTITY_CONSUMPTION_UNDECLAREDfires when a resolved dependency omits the mode its consumer actually uses.Review finding RVR-P2-002.